Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc0b8602 authored by Ats Jenk's avatar Ats Jenk
Browse files

Show highlight around the selected overview tile 

Enable highlight around focused overview item when desktop windowing
prototypes are enabled.
This highlight was built for and enabled with keyboard quickswitch feature.
We don't support quickswitch on desktop yet.
Disable the quickswitch, but keep the border highlight.

Bug: 269342116
Test: enable desktop windowing proto, use an external keyboard and
  alt+tab to switch between apps, observe highlight in overview, no
  quickswitch popup
Test: enable desktop windowing proto, enable
  ENABLE_KEYBOARD_QUICK_SWITCH, observe that alt+tab still opens
  overview
Test: disable desktop windowing proto, enable
  ENABLE_KEYBOARD_QUICK_SWITCH, observe alt+tab opens the quickswitch
  popup, and highlights in overview
Change-Id: I15b36f082610f4ce38143856c84fef723f1b8ba0
parent 5839ffa7

quickstep/src/com/android/quickstep/OverviewCommandHelper.java

+6 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ import com.android.launcher3.statemanager.StatefulActivity; 
import com.android.launcher3.taskbar.TaskbarUIController;

import com.android.launcher3.util.RunnableList;

import com.android.quickstep.RecentsAnimationCallbacks.RecentsAnimationListener;

import com.android.quickstep.views.DesktopTaskView;

import com.android.quickstep.views.RecentsView;

import com.android.quickstep.views.TaskView;

import com.android.systemui.shared.recents.model.ThumbnailData;
@@ -185,6 +186,11 @@ public class OverviewCommandHelper { 
                    && dp != null

                    && (dp.isTablet || dp.isTwoPanels);



            if (DesktopTaskView.DESKTOP_MODE_SUPPORTED) {

                // TODO(b/268075592): add support for quickswitch to/from desktop

                allowQuickSwitch = false;

            }



            if (cmd.type == TYPE_HIDE) {

                if (!allowQuickSwitch) {

                    return true;

quickstep/src/com/android/quickstep/views/TaskView.java

+5 −2
Original line number Diff line number Diff line
@@ -431,9 +431,12 @@ public class TaskView extends FrameLayout implements Reusable { 
        mCurrentFullscreenParams = new FullscreenDrawParams(context);

        mDigitalWellBeingToast = new DigitalWellBeingToast(mActivity, this);



        setWillNotDraw(!FeatureFlags.ENABLE_KEYBOARD_QUICK_SWITCH.get());

        boolean keyboardFocusHighlightEnabled = FeatureFlags.ENABLE_KEYBOARD_QUICK_SWITCH.get()

                || DesktopTaskView.DESKTOP_MODE_SUPPORTED;



        mBorderAnimator = !FeatureFlags.ENABLE_KEYBOARD_QUICK_SWITCH.get()

        setWillNotDraw(!keyboardFocusHighlightEnabled);



        mBorderAnimator = !keyboardFocusHighlightEnabled

                ? null

                : new BorderAnimator(

                        /* borderBoundsBuilder= */ this::updateBorderBounds,