Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4cc4b13 authored Aug 29, 2023 by Saumya Prakash

Remove extraneous transition from Overview to Home screen

Previously, users used to be able to swipe down near the
bottom of the screen to leave overview. This was causing the taskbar to
animate to home while still in overview (and causing jank). Since this isn't expected behavior for
how to leave overview, this change removes that method.

Flag: N/A
Fix: 284416178
Test: Completed multiple transitions (ex. Overview to home) with 3
button nav and gesture nav. Ensured swiping down from below the recents
task does not go to the home screen while not affecting other
transitions.

Change-Id: I8cdfde71117dd947174d9c3c3a7f834fbeaddcca

parent 0ff8103c

quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/NoButtonNavbarToOverviewTouchController.java

+0 −3

Original line number	Diff line number	Diff line
		@@ -119,9 +119,6 @@ public class NoButtonNavbarToOverviewTouchController extends PortraitStatesTouch
		protected LauncherState getTargetState(LauncherState fromState, boolean isDragTowardPositive) {
		if (fromState == NORMAL && mDidTouchStartInNavBar) {
		return HINT_STATE;
		} else if (fromState == OVERVIEW && isDragTowardPositive) {
		// Don't allow swiping up to all apps.
		return OVERVIEW;
		}
		return super.getTargetState(fromState, isDragTowardPositive);
		}

quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/PortraitStatesTouchController.java

+0 −2

Original line number	Diff line number	Diff line
		@@ -96,8 +96,6 @@ public class PortraitStatesTouchController extends AbstractStateChangeTouchContr
		return FeatureFlags.ENABLE_ALL_APPS_FROM_OVERVIEW.get()
		? mLauncher.getStateManager().getLastState()
		: NORMAL;
		} else if (fromState == OVERVIEW) {
		return isDragTowardPositive ? OVERVIEW : NORMAL;
		} else if (fromState == NORMAL && isDragTowardPositive) {
		return ALL_APPS;
		}