Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c16c2813 authored by Alina Zaidi's avatar Alina Zaidi
Browse files

Fix few A11y/ UI bugs for widget pickers 

- Add a subtext in pin widget dialog informing users how to add widget
manually. This is not important for accessibility, as drag and drop is through an
action item for visually impaired users.
- Update search bar text hint color so that it passes accessibility test.

Bug: 182994384
Bug: 182993604
Test: Manually Tested using accessibility scanner app and talkback
Change-Id: I5a49d0bc3e5973b76c41b2a178af509e96a3cdd7
parent 2b5124ec

res/layout/add_item_confirmation_activity.xml

+9 −0
Original line number Diff line number Diff line
@@ -36,6 +36,15 @@ 
        android:singleLine="true"

        android:maxLines="1" />



    <TextView

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:gravity="center_horizontal"

        android:paddingVertical="8dp"

        android:text="@string/add_item_request_drag_hint"

        android:textSize="14sp"

        android:importantForAccessibility="no"/>



    <include layout="@layout/widget_cell"

        android:id="@+id/widget_cell"

        android:layout_width="match_parent"

res/layout/widgets_search_bar.xml

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ 
        android:inputType="text"

        android:imeOptions="actionSearch"

        android:textColor="?android:attr/textColorPrimary"

        android:textColorHint="?android:attr/textColorTertiary"/>

        android:textColorHint="?android:attr/textColorSecondary"/>



    <ImageButton

        android:id="@+id/widgets_search_cancel_button"

res/values/strings.xml

+3 −2
Original line number Diff line number Diff line
@@ -55,8 +55,9 @@ 
    <string name="widget_dims_format">%1$d \u00d7 %2$d</string>

    <!-- Accessibility spoken message format for the dimensions of a widget in the drawer -->

    <string name="widget_accessible_dims_format">%1$d wide by %2$d high</string>

    <!-- Message to tell the user to press and hold a widget/icon to add it  -->

    <string name="add_item_request_drag_hint">Touch &amp; hold to place manually</string>

    <!-- Message to tell the user to press and hold a widget/icon to add it to the home screen.

         [CHAR LIMIT=NONE]  -->

    <string name="add_item_request_drag_hint">Touch &amp; hold the widget to move it around the Home screen</string>

    <!-- Button label to automatically add a widget to home screen [CHAR_LIMIT=50] -->

    <string name="add_to_home_screen">Add to Home screen</string>

    <!-- Label for showing the number of widgets an app has in the full widgets picker.