Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a56cb841 authored by Jon Miranda's avatar Jon Miranda
Browse files

Update extra space allocations for taller devices. 

- Take less space from cells
- Distribute some of the empty space above the workspace
- Already confirmed from previous testing that these thresholds
  only affect taller devices

Bug: 194688362
Test: long press on app icons,
      test drag and drop bounds
      test drop target bounds
      test folder opening bounds
      test all grids on taller devices

Change-Id: If90b7663ab4afedca1193bdd73a0ae38a1f25243
parent 25399db1

src/com/android/launcher3/DeviceProfile.java

+5 −4
Original line number Diff line number Diff line
@@ -386,14 +386,15 @@ public class DeviceProfile { 


                // For devices with more extra space, we take a larger piece from each cell.

                int piece = extraSpace < Utilities.dpToPx(TALL_DEVICE_MORE_EXTRA_SPACE_THRESHOLD_DP)

                        ? 5 : 3;

                        ? 7 : 5;



                int extraSpace = ((getCellSize().y - iconSizePx - iconDrawablePaddingPx * 2)

                        * inv.numRows) / piece;



                int halfExtraSpace = extraSpace / 2;

                hotseatBarTopPaddingPx += halfExtraSpace;

                hotseatBarSizeExtraSpacePx = halfExtraSpace;

                workspaceTopPadding = extraSpace / 8;

                int halfLeftOver = (extraSpace - workspaceTopPadding) / 2;

                hotseatBarTopPaddingPx += halfLeftOver;

                hotseatBarSizeExtraSpacePx = halfLeftOver;

            } else {

                // ie. For a display with a large aspect ratio, we can keep the icons on the

                // workspace in portrait mode closer together by adding more height to the hotseat.