Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f54d597 authored by Vinit Nayak's avatar Vinit Nayak
Browse files

Round split layout values instead of using int cast 

* Silly us, we forgot that int casting always floors.
Math.round() does a mathematical round.

Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation.

Change-Id: I068c030ce6b86fc12faee7778c0d87a0d5aea487
parent c7d676ce

src/com/android/launcher3/touch/LandscapePagedViewHandler.java

+3 −3
Original line number Diff line number Diff line
@@ -504,9 +504,9 @@ public class LandscapePagedViewHandler implements PagedOrientationHandler { 
            DeviceProfile dp, boolean isRtl) {

        int spaceAboveSnapshot = dp.overviewTaskThumbnailTopMarginPx;

        int totalThumbnailHeight = parentHeight - spaceAboveSnapshot;

        int dividerBar = splitBoundsConfig.appsStackedVertically

                ? (int) (splitBoundsConfig.dividerHeightPercent * parentHeight)

                : (int) (splitBoundsConfig.dividerWidthPercent * parentWidth);

        int dividerBar = Math.round(totalThumbnailHeight * (splitBoundsConfig.appsStackedVertically

                ? splitBoundsConfig.dividerHeightPercent

                : splitBoundsConfig.dividerWidthPercent));

        int primarySnapshotHeight;

        int primarySnapshotWidth;

        int secondarySnapshotHeight;

src/com/android/launcher3/touch/PortraitPagedViewHandler.java

+3 −3
Original line number Diff line number Diff line
@@ -630,9 +630,9 @@ public class PortraitPagedViewHandler implements PagedOrientationHandler { 
            DeviceProfile dp, boolean isRtl) {

        int spaceAboveSnapshot = dp.overviewTaskThumbnailTopMarginPx;

        int totalThumbnailHeight = parentHeight - spaceAboveSnapshot;

        int dividerBar = splitBoundsConfig.appsStackedVertically

                ? (int) (splitBoundsConfig.dividerHeightPercent * parentHeight)

                : (int) (splitBoundsConfig.dividerWidthPercent * parentWidth);

        int dividerBar = Math.round(splitBoundsConfig.appsStackedVertically

                ? splitBoundsConfig.dividerHeightPercent * totalThumbnailHeight

                : splitBoundsConfig.dividerWidthPercent * totalThumbnailHeight);

        int primarySnapshotHeight;

        int primarySnapshotWidth;

        int secondarySnapshotHeight;

src/com/android/launcher3/touch/SeascapePagedViewHandler.java

+3 −3
Original line number Diff line number Diff line
@@ -283,9 +283,9 @@ public class SeascapePagedViewHandler extends LandscapePagedViewHandler { 
        // (portrait bottom) and secondary is on the right (portrait top)

        int spaceAboveSnapshot = dp.overviewTaskThumbnailTopMarginPx;

        int totalThumbnailHeight = parentHeight - spaceAboveSnapshot;

        int dividerBar = splitBoundsConfig.appsStackedVertically

                ? (int) (splitBoundsConfig.dividerHeightPercent * parentHeight)

                : (int) (splitBoundsConfig.dividerWidthPercent * parentWidth);

        int dividerBar = Math.round(totalThumbnailHeight * (splitBoundsConfig.appsStackedVertically

                ? splitBoundsConfig.dividerHeightPercent

                : splitBoundsConfig.dividerWidthPercent));

        int primarySnapshotHeight;

        int primarySnapshotWidth;

        int secondarySnapshotHeight;