Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d8412f5 authored by Schneider Victor-tulias's avatar Schneider Victor-tulias
Browse files

Update logging to help debug b/200572078 

The class name logged in a repro of b/200572078 was insufficient after updated logs. Added more logging to get a pointer and stack trace when callbacks are added.

Test: ran launcher and checked logs
Bug: 200572078
Change-Id: I01bf98f488204311415a3946d66d99f656387cc4
parent fa8860a1

src/com/android/launcher3/LauncherModel.java

+7 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ import com.android.launcher3.pm.InstallSessionTracker; 
import com.android.launcher3.pm.PackageInstallInfo;

import com.android.launcher3.pm.UserCache;

import com.android.launcher3.shortcuts.ShortcutRequest;

import com.android.launcher3.testing.TestProtocol;

import com.android.launcher3.util.IntSet;

import com.android.launcher3.util.ItemInfoMatcher;

import com.android.launcher3.util.PackageUserKey;
@@ -346,6 +347,12 @@ public class LauncherModel extends LauncherApps.Callback implements InstallSessi 
    public void addCallbacks(Callbacks callbacks) {

        Preconditions.assertUIThread();

        synchronized (mCallbacksList) {

            if (TestProtocol.sDebugTracing) {

                Log.d(TestProtocol.NULL_INT_SET, "addCallbacks pointer: "

                        + callbacks

                        + ", name: "

                        + callbacks.getClass().getName(), new Exception());

            }

            mCallbacksList.add(callbacks);

        }

    }

src/com/android/launcher3/model/BaseLoaderResults.java

+3 −1
Original line number Diff line number Diff line
@@ -177,7 +177,9 @@ public abstract class BaseLoaderResults { 
            if (TestProtocol.sDebugTracing) {

                Log.d(TestProtocol.NULL_INT_SET, "bind (1) currentScreenIds: "

                        + currentScreenIds

                        + ", mCallBacks: "

                        + ", pointer: "

                        + mCallbacks

                        + ", name: "

                        + mCallbacks.getClass().getName());

            }

            filterCurrentWorkspaceItems(currentScreenIds, mWorkspaceItems, currentWorkspaceItems,