Commit 7fcbd237 authored Oct 18, 2019 by vadimt Committed by Vadim Tryshev Oct 18, 2019

Fixing activity leak on config change

If attachTo happens before the view is attached to window,
ViewOnDrawExecutor hooks to the tree observer twice (second time from
onViewAttachedToWindow). It only unhooks once.

Since tree observer is global, this leads to leaking the activity, and
besides, all old activities getting the events from the tree observer.

Bug: 139137636
Change-Id: Ie2641b8f3614545052fe34ad6588b070c3b82a33
(cherry picked from commit ebb5c753)

parent c3a688a9

src/com/android/launcher3/util/ViewOnDrawExecutor.java

+3 −1

Original line number	Diff line number	Diff line
		@@ -55,8 +55,10 @@ public class ViewOnDrawExecutor implements Executor, OnDrawListener, Runnable,
		mLoadAnimationCompleted = true;
		}

		if (mAttachedView.isAttachedToWindow()) {
		attachObserver();
		}
		}

		private void attachObserver() {
		if (!mCompleted) {