Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7371e4da authored by vadimt's avatar vadimt Committed by Vadim Tryshev
Browse files

Waiting for Launcher model load in out-of-proc tests. 

Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
Merged-in: Ia9caf20e4a2d93298adf4249ca815ad79bced802
parent 7cb5b73d

quickstep/recents_ui_overrides/src/com/android/quickstep/QuickstepTestInformationHandler.java

+5 −6
Original line number Diff line number Diff line
@@ -36,12 +36,6 @@ public class QuickstepTestInformationHandler extends TestInformationHandler { 
                return response;

            }



            case TestProtocol.REQUEST_IS_LAUNCHER_INITIALIZED: {

                response.putBoolean(TestProtocol.TEST_INFO_RESPONSE_FIELD,

                        TouchInteractionService.isInitialized());

                return response;

            }



            case TestProtocol.REQUEST_HOTSEAT_TOP: {

                if (mLauncher == null) return null;
@@ -80,4 +74,9 @@ public class QuickstepTestInformationHandler extends TestInformationHandler { 


        return super.call(method);

    }



    @Override

    protected boolean isLauncherInitialized() {

        return super.isLauncherInitialized() && TouchInteractionService.isInitialized();

    }

}

src/com/android/launcher3/testing/TestInformationHandler.java

+7 −1
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ import com.android.launcher3.DeviceProfile; 
import com.android.launcher3.InvariantDeviceProfile;

import com.android.launcher3.Launcher;

import com.android.launcher3.LauncherAppState;

import com.android.launcher3.LauncherModel;

import com.android.launcher3.LauncherState;

import com.android.launcher3.MainThreadExecutor;

import com.android.launcher3.R;
@@ -82,7 +83,7 @@ public class TestInformationHandler implements ResourceBasedOverride { 
            }



            case TestProtocol.REQUEST_IS_LAUNCHER_INITIALIZED: {

                response.putBoolean(TestProtocol.TEST_INFO_RESPONSE_FIELD, true);

                response.putBoolean(TestProtocol.TEST_INFO_RESPONSE_FIELD, isLauncherInitialized());

                break;

            }
@@ -152,4 +153,9 @@ public class TestInformationHandler implements ResourceBasedOverride { 
        }

        return response;

    }



    protected boolean isLauncherInitialized() {

        final LauncherModel model = LauncherAppState.getInstance(mContext).getModel();

        return model.getCallback() == null || model.isModelLoaded();

    }

}
 
 No newline at end of file

tests/src/com/android/launcher3/ui/DefaultLayoutProviderTest.java

+0 −3
Original line number Diff line number Diff line
@@ -73,7 +73,6 @@ public class DefaultLayoutProviderTest extends AbstractLauncherUiTest { 


        // Launch the home activity

        mDevice.pressHome();

        waitForModelLoaded();



        mLauncher.getWorkspace().getHotseatAppIcon(getSettingsApp().getLabel().toString());

    }
@@ -89,7 +88,6 @@ public class DefaultLayoutProviderTest extends AbstractLauncherUiTest { 


        // Launch the home activity

        mDevice.pressHome();

        waitForModelLoaded();



        // Verify widget present

        assertTrue("Widget is not present",
@@ -106,7 +104,6 @@ public class DefaultLayoutProviderTest extends AbstractLauncherUiTest { 


        // Launch the home activity

        mDevice.pressHome();

        waitForModelLoaded();



        mLauncher.getWorkspace().getHotseatFolder("Folder: Copy");

    }

tests/src/com/android/launcher3/ui/widget/BindWidgetTest.java

+0 −1
Original line number Diff line number Diff line
@@ -271,7 +271,6 @@ public class BindWidgetTest extends AbstractLauncherUiTest { 


        // Launch the home activity

        mDevice.pressHome();

        waitForModelLoaded();

    }



    private void verifyWidgetPresent(LauncherAppWidgetProviderInfo info) {