Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f064018 authored by Sunny Goyal's avatar Sunny Goyal
Browse files

Fixing potential ConcurrentModificationException 

mBgDeepShortcutMap is only accessed on the background thread. But
the same instance of list of values was getting passed to the UI
thread, instead of being cloned.

Change-Id: Ie7d0442d895304489ce9323ea872b9091d668ae5
parent bdc9f325

src/com/android/launcher3/LauncherModel.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -2849,8 +2849,7 @@ public class LauncherModel extends BroadcastReceiver 
    }

    }





    public void bindDeepShortcuts() {

    public void bindDeepShortcuts() {

        final MultiHashMap<ComponentKey, String> shortcutMapCopy = new MultiHashMap<>();

        final MultiHashMap<ComponentKey, String> shortcutMapCopy = mBgDeepShortcutMap.clone();

        shortcutMapCopy.putAll(mBgDeepShortcutMap);

        Runnable r = new Runnable() {

        Runnable r = new Runnable() {

            @Override

            @Override

            public void run() {

            public void run() {

src/com/android/launcher3/util/MultiHashMap.java

+32 −0
Original line number Original line Diff line number Diff line 
/*

 * Copyright (C) 2016 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.launcher3.util;

package com.android.launcher3.util;





import java.util.ArrayList;

import java.util.ArrayList;
@@ -7,6 +23,13 @@ import java.util.HashMap; 
 * A utility map from keys to an ArrayList of values.

 * A utility map from keys to an ArrayList of values.

 */

 */

public class MultiHashMap<K, V> extends HashMap<K, ArrayList<V>> {

public class MultiHashMap<K, V> extends HashMap<K, ArrayList<V>> {



    public MultiHashMap() { }



    public MultiHashMap(int size) {

        super(size);

    }



    public void addToList(K key, V value) {

    public void addToList(K key, V value) {

        ArrayList<V> list = get(key);

        ArrayList<V> list = get(key);

        if (list == null) {

        if (list == null) {
@@ -17,4 +40,13 @@ public class MultiHashMap<K, V> extends HashMap<K, ArrayList<V>> { 
            list.add(value);

            list.add(value);

        }

        }

    }

    }



    @Override

    public MultiHashMap<K, V> clone() {

        MultiHashMap<K, V> map = new MultiHashMap<>(size());

        for (Entry<K, ArrayList<V>> entry : entrySet()) {

            map.put(entry.getKey(), new ArrayList<V>(entry.getValue()));

        }

        return map;

    }

}
 
}