Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 488bca79 authored by Tony Wickham's avatar Tony Wickham
Browse files

Remove TaskbarLauncherStateController#setIconAlpha() 

Instead use setTaskbarViewVisible directly. Now that we stash when going to overview, we shouldn't have any launcher state where we need to fade out TaskbarView icons

Test: quick switch from home (follow up CL)
Bug: 194728611
Change-Id: I03e1fa4037b7e8a08494f6b7e065d144c4bc4e1b
parent b78cbf29

quickstep/src/com/android/launcher3/taskbar/TaskbarLauncherStateController.java

+5 −39
Original line number Original line Diff line number Diff line
@@ -15,7 +15,6 @@ 
 */

 */

package com.android.launcher3.taskbar;

package com.android.launcher3.taskbar;





import static com.android.launcher3.LauncherState.HOTSEAT_ICONS;

import static com.android.launcher3.taskbar.TaskbarStashController.FLAG_IN_APP;

import static com.android.launcher3.taskbar.TaskbarStashController.FLAG_IN_APP;

import static com.android.launcher3.taskbar.TaskbarStashController.FLAG_IN_STASHED_LAUNCHER_STATE;

import static com.android.launcher3.taskbar.TaskbarStashController.FLAG_IN_STASHED_LAUNCHER_STATE;

import static com.android.launcher3.taskbar.TaskbarStashController.TASKBAR_STASH_DURATION;

import static com.android.launcher3.taskbar.TaskbarStashController.TASKBAR_STASH_DURATION;
@@ -68,9 +67,6 @@ import java.util.function.Supplier; 
    private int mPrevState;

    private int mPrevState;

    private int mState;

    private int mState;





    private LauncherState mTargetStateOverride = null;

    private LauncherState mTargetStateOverrideForStateTransition = null;



    private boolean mIsAnimatingToLauncherViaGesture;

    private boolean mIsAnimatingToLauncherViaGesture;

    private boolean mIsAnimatingToLauncherViaResume;

    private boolean mIsAnimatingToLauncherViaResume;
@@ -79,7 +75,6 @@ import java.util.function.Supplier; 




                @Override

                @Override

                public void onStateTransitionStart(LauncherState toState) {

                public void onStateTransitionStart(LauncherState toState) {

                    mTargetStateOverrideForStateTransition = toState;

                    updateStateForFlag(FLAG_TRANSITION_STATE_START_STASHED,

                    updateStateForFlag(FLAG_TRANSITION_STATE_START_STASHED,

                            toState.isTaskbarStashed());

                            toState.isTaskbarStashed());

                    applyState();

                    applyState();
@@ -134,18 +129,6 @@ import java.util.function.Supplier; 
        updateStateForFlag(FLAG_RECENTS_ANIMATION_RUNNING, true);

        updateStateForFlag(FLAG_RECENTS_ANIMATION_RUNNING, true);

        animatorSet.play(stashController.applyStateWithoutStart(duration));

        animatorSet.play(stashController.applyStateWithoutStart(duration));

        animatorSet.play(applyState(duration, false));

        animatorSet.play(applyState(duration, false));

        animatorSet.addListener(new AnimatorListenerAdapter() {

            @Override

            public void onAnimationEnd(Animator animator) {

                mTargetStateOverride = null;

                animator.removeListener(this);

            }



            @Override

            public void onAnimationStart(Animator animator) {

                mTargetStateOverride = toState;

            }

        });





        TaskBarRecentsAnimationListener listener = new TaskBarRecentsAnimationListener(callbacks);

        TaskBarRecentsAnimationListener listener = new TaskBarRecentsAnimationListener(callbacks);

        callbacks.addListener(listener);

        callbacks.addListener(listener);
@@ -284,7 +267,6 @@ import java.util.function.Supplier; 
                        // Reset hotseat alpha to default

                        // Reset hotseat alpha to default

                        mLauncher.getHotseat().setIconsAlpha(1);

                        mLauncher.getHotseat().setIconsAlpha(1);

                    }

                    }

                    mTargetStateOverrideForStateTransition = null;

                }

                }





                @Override

                @Override
@@ -296,8 +278,6 @@ import java.util.function.Supplier; 
            animatorSet.play(mIconAlignmentForLauncherState.animateToValue(

            animatorSet.play(mIconAlignmentForLauncherState.animateToValue(

                    getCurrentIconAlignmentRatioForLauncherState(),

                    getCurrentIconAlignmentRatioForLauncherState(),

                    isTransitionStateStashed ? 0 : 1));

                    isTransitionStateStashed ? 0 : 1));

        } else {

            mTargetStateOverrideForStateTransition = null;

        }

        }

    }

    }
@@ -318,20 +298,14 @@ import java.util.function.Supplier; 
    }

    }





    private void onIconAlignmentRatioChangedForStateTransition() {

    private void onIconAlignmentRatioChangedForStateTransition() {

        onIconAlignmentRatioChanged(

        onIconAlignmentRatioChanged(this::getCurrentIconAlignmentRatioForLauncherState);

                mTargetStateOverrideForStateTransition != null

                        ? mTargetStateOverrideForStateTransition

                        : mLauncher.getStateManager().getState(),

                this::getCurrentIconAlignmentRatioForLauncherState);

    }

    }





    private void onIconAlignmentRatioChanged() {

    private void onIconAlignmentRatioChanged() {

        onIconAlignmentRatioChanged(mTargetStateOverride != null ? mTargetStateOverride

        onIconAlignmentRatioChanged(this::getCurrentIconAlignmentRatio);

                : mLauncher.getStateManager().getState(), this::getCurrentIconAlignmentRatio);

    }

    }





    private void onIconAlignmentRatioChanged(LauncherState state,

    private void onIconAlignmentRatioChanged(Supplier<Float> alignmentSupplier) {

            Supplier<Float> alignmentSupplier) {

        if (mControllers == null) {

        if (mControllers == null) {

            return;

            return;

        }

        }
@@ -341,7 +315,8 @@ import java.util.function.Supplier; 




        mTaskbarBackgroundAlpha.updateValue(1 - alignment);

        mTaskbarBackgroundAlpha.updateValue(1 - alignment);





        setIconAlpha(state, alignment);

        // Switch taskbar and hotseat in last frame

        setTaskbarViewVisible(alignment < 1);

    }

    }





    private float getCurrentIconAlignmentRatio() {

    private float getCurrentIconAlignmentRatio() {
@@ -352,15 +327,6 @@ import java.util.function.Supplier; 
        return mIconAlignmentForLauncherState.value;

        return mIconAlignmentForLauncherState.value;

    }

    }





    private void setIconAlpha(LauncherState state, float progress) {

        if ((state.getVisibleElements(mLauncher) & HOTSEAT_ICONS) != 0) {

            // If the hotseat icons are visible, then switch taskbar in last frame

            setTaskbarViewVisible(progress < 1);

        } else {

            mIconAlphaForHome.setValue(1 - progress);

        }

    }



    private void setTaskbarViewVisible(boolean isVisible) {

    private void setTaskbarViewVisible(boolean isVisible) {

        mIconAlphaForHome.setValue(isVisible ? 1 : 0);

        mIconAlphaForHome.setValue(isVisible ? 1 : 0);

    }

    }