Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 234b1e06 authored by Hyunyoung Song's avatar Hyunyoung Song Committed by Android (Google) Code Review
Browse files

Merge "Revert "Add entry and cursor location in GetSuggestionRequest"" into tm-dev

parents 3b6ba0d2 355bd482
Loading
Loading
Loading
Loading
+2 −4
Original line number Diff line number Diff line
@@ -100,14 +100,12 @@ public class AllAppsSearchBarController
    @Override
    public void afterTextChanged(final Editable s) {
        mQuery = s.toString();
        mInput.getSelectionStart();
        if (mQuery.isEmpty()) {
            mSearchAlgorithm.cancel(true);
            mCallback.clearSearchResult();
        } else {
            mSearchAlgorithm.cancel(false);
            mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), mTextConversions,
                    mCallback);
            mSearchAlgorithm.doSearch(mQuery, mTextConversions, mCallback);
        }
    }

@@ -117,7 +115,7 @@ public class AllAppsSearchBarController
        }
        // If play store continues auto updating an app, we want to show partial result.
        mSearchAlgorithm.cancel(false);
        mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), mCallback);
        mSearchAlgorithm.doSearch(mQuery, mCallback);
    }

    @Override
+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ public class DefaultAppSearchAlgorithm implements SearchAlgorithm<AdapterItem> {
    }

    @Override
    public void doSearch(String query, int cursorLocation, SearchCallback<AdapterItem> callback) {
    public void doSearch(String query, SearchCallback<AdapterItem> callback) {
        mAppState.getModel().enqueueModelUpdateTask(new BaseModelUpdateTask() {
            @Override
            public void execute(LauncherAppState app, BgDataModel dataModel, AllAppsList apps) {
+3 −4
Original line number Diff line number Diff line
@@ -25,14 +25,13 @@ public interface SearchAlgorithm<T> {
    /**
     * Performs search and sends the result to {@link SearchCallback}.
     */
    void doSearch(String query, int cursorLocation, SearchCallback<T> callback);
    void doSearch(String query, SearchCallback<T> callback);

    /**
     * Performs search with {@code query} and the {@code suggestedQueries}/
     */
    default void doSearch(String query, int cursorLocation, String[] suggestedQueries,
            SearchCallback<T> callback) {
        doSearch(query, cursorLocation, callback);
    default void doSearch(String query, String[] suggestedQueries, SearchCallback<T> callback) {
        doSearch(query, callback);
    }

    /**
+1 −2
Original line number Diff line number Diff line
@@ -48,8 +48,7 @@ public final class SimpleWidgetsSearchAlgorithm implements SearchAlgorithm<Widge
    }

    @Override
    public void doSearch(String query, int cursorLocation,
            SearchCallback<WidgetsListBaseEntry> callback) {
    public void doSearch(String query, SearchCallback<WidgetsListBaseEntry> callback) {
        ArrayList<WidgetsListBaseEntry> result = getFilteredWidgets(mDataProvider, query);
        mResultHandler.post(() -> callback.onSearchResult(query, result));
    }
+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ public class WidgetsSearchBarController implements TextWatcher,
        } else {
            mSearchAlgorithm.cancel(/* interruptActiveRequests= */ false);
            mSearchModeListener.enterSearchMode();
            mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), this);
            mSearchAlgorithm.doSearch(mQuery, this);
            mCancelButton.setVisibility(VISIBLE);
        }
    }
Loading