Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21d8230b authored by Vinit Nayak's avatar Vinit Nayak
Browse files

Prevent rotating TaskMenuViewWithArrow for large screen 

* Only attempt to rotate TaskMenuView on
fake rotation

Fixes: 254198019
Test: Rotation on large screen w/ TaskMenu open doesn't
crash

Change-Id: If8ae8c018e9cc8cb80a2ec3313f5e8d0fda2e148
parent 0c1714bb

quickstep/src/com/android/quickstep/views/RecentsView.java

+7 −0
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ import androidx.annotation.Nullable; 
import androidx.annotation.UiThread;

import androidx.core.graphics.ColorUtils;



import com.android.launcher3.AbstractFloatingView;

import com.android.launcher3.BaseActivity;

import com.android.launcher3.BaseActivity.MultiWindowModeChangedListener;

import com.android.launcher3.DeviceProfile;
@@ -2241,8 +2242,14 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T 
        for (int i = 0; i < getTaskViewCount(); i++) {

            requireTaskViewAt(i).setOrientationState(mOrientationState);

        }

        boolean shouldRotateMenuForFakeRotation =

                !mOrientationState.isRecentsActivityRotationAllowed();

        if (!shouldRotateMenuForFakeRotation) {

            return;

        }

        TaskMenuView tv = (TaskMenuView) getTopOpenViewWithType(mActivity, TYPE_TASK_MENU);

        if (tv != null) {

            // Rotation is supported on phone (details at b/254198019#comment4)

            tv.onRotationChanged();

        }

    }