Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fda7aece authored by Santiago Etchebehere's avatar Santiago Etchebehere
Browse files

Fix more Activity leaks 

Fix more leaks from GridFramgent2 and ClockSettingsFragment

Test: ran profiler, switched wallpapers via quick-switch, colors, manually
set live wallpapers, clocks, and changed affordances
Bug: 285978251

Change-Id: I8c37ef3338ba3de2a259ffc13ca3e7eac3044071
parent c1e062b9

src/com/android/customization/model/grid/ui/fragment/GridFragment2.kt

+1 −1
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ class GridFragment2 : AppbarFragment() { 
                    wallpaperInteractor = wallpaperInteractor,

                    screen = CustomizationSections.Screen.HOME_SCREEN,

                ),

            lifecycleOwner = this,

            lifecycleOwner = viewLifecycleOwner,

            offsetToStart = false,

            onWallpaperPreviewDirty = { activity?.recreate() },

        )

src/com/android/customization/module/ThemePickerInjector.kt

+2 −2
Original line number Diff line number Diff line
@@ -237,8 +237,8 @@ open class ThemePickerInjector : WallpaperPicker2Injector(), CustomizationInject 
                            client =

                                WallpaperClientImpl(

                                    context = appContext,

                                    infoFactory = getCurrentWallpaperInfoFactory(context),

                                    wallpaperManager = WallpaperManager.getInstance(context)

                                    infoFactory = getCurrentWallpaperInfoFactory(appContext),

                                    wallpaperManager = WallpaperManager.getInstance(appContext)

                                ),

                            wallpaperPreferences = getPreferences(context = appContext),

                            backgroundDispatcher = Dispatchers.IO,

src/com/android/customization/picker/clock/ui/fragment/ClockSettingsFragment.kt

+1 −1
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ class ClockSettingsFragment : AppbarFragment() { 
                )

                .get(),

            injector.getClockViewFactory(activity),

            this@ClockSettingsFragment,

            viewLifecycleOwner,

        )



        return view