Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6507b7af authored by Santiago Etchebehere's avatar Santiago Etchebehere
Browse files

Accessibility fixes 

Remove min height in preview cards to allow better resizing
when display and font are set to largest size.
Bold the current bottom nav item so we don't depend only
on color for the selection.

Bug: 130398264
Fixes: 130400266
Change-Id: Ic612b385e205672920860f997e2bbe5d4bd1853b
parent 258262ab

res/layout/fragment_theme_picker.xml

+0 −1
Original line number Original line Diff line number Diff line
@@ -41,7 +41,6 @@ 
                app:layout_constraintBottom_toTopOf="@id/options_container"

                app:layout_constraintBottom_toTopOf="@id/options_container"

                app:layout_constraintEnd_toEndOf="parent"

                app:layout_constraintEnd_toEndOf="parent"

                app:layout_constraintHeight_max="@dimen/preview_pager_max_height"

                app:layout_constraintHeight_max="@dimen/preview_pager_max_height"

                app:layout_constraintHeight_min="@dimen/preview_pager_min_height"

                app:layout_constraintStart_toStartOf="parent"

                app:layout_constraintStart_toStartOf="parent"

                app:layout_constraintTop_toTopOf="parent"

                app:layout_constraintTop_toTopOf="parent"

                app:layout_constraintVertical_bias="0.0"

                app:layout_constraintVertical_bias="0.0"

res/layout/theme_component_preview.xml

+1 −0
Original line number Original line Diff line number Diff line
@@ -23,6 +23,7 @@ 
    android:id="@+id/theme_preview_card_background"

    android:id="@+id/theme_preview_card_background"

    android:layout_width="match_parent"

    android:layout_width="match_parent"

    android:layout_height="match_parent"

    android:layout_height="match_parent"

    android:clipToPadding="false"

    android:maxHeight="@dimen/preview_theme_max_height"

    android:maxHeight="@dimen/preview_theme_max_height"

    android:minHeight="@dimen/preview_theme_min_height"

    android:minHeight="@dimen/preview_theme_min_height"

    android:paddingHorizontal="@dimen/preview_card_padding"

    android:paddingHorizontal="@dimen/preview_card_padding"

res/values/dimens.xml

+1 −1
Original line number Original line Diff line number Diff line
@@ -85,7 +85,7 @@ 
    <dimen name="preview_theme_cover_content_bottom">@dimen/preview_theme_content_bottom</dimen>

    <dimen name="preview_theme_cover_content_bottom">@dimen/preview_theme_content_bottom</dimen>





    <dimen name="font_preview_body_width">200dp</dimen>

    <dimen name="font_preview_body_width">200dp</dimen>

    <dimen name="font_preview_divider_gap">30dp</dimen>

    <dimen name="font_preview_divider_gap">24dp</dimen>





    <dimen name="custom_theme_nav_height">56dp</dimen>

    <dimen name="custom_theme_nav_height">56dp</dimen>

res/values/styles.xml

+5 −1
Original line number Original line Diff line number Diff line
@@ -44,7 +44,7 @@ 
    <style name="BottomNavStyle">

    <style name="BottomNavStyle">

        <item name="itemIconTint">@color/bottom_nav_item_color</item>

        <item name="itemIconTint">@color/bottom_nav_item_color</item>

        <item name="itemTextColor">@color/bottom_nav_item_color</item>

        <item name="itemTextColor">@color/bottom_nav_item_color</item>

        <item name="itemTextAppearanceActive">@style/BottomNavTextAppearance</item>

        <item name="itemTextAppearanceActive">@style/BottomNavTextAppearanceActive</item>

        <item name="itemTextAppearanceInactive">@style/BottomNavTextAppearance</item>

        <item name="itemTextAppearanceInactive">@style/BottomNavTextAppearance</item>

        <item name="itemBackground">?android:attr/selectableItemBackgroundBorderless</item>

        <item name="itemBackground">?android:attr/selectableItemBackgroundBorderless</item>

        <item name="android:background">?android:colorPrimary</item>

        <item name="android:background">?android:colorPrimary</item>
@@ -54,6 +54,10 @@ 
        <item name="android:textSize">@dimen/bottom_navbar_font_text_size</item>

        <item name="android:textSize">@dimen/bottom_navbar_font_text_size</item>

    </style>

    </style>





    <style name="BottomNavTextAppearanceActive" parent="BottomNavTextAppearance">

        <item name="android:textStyle">bold</item>

    </style>



    <!-- Common components and widgets -->

    <!-- Common components and widgets -->

    <style name="HeaderTextAppearance" parent="@android:style/TextAppearance.DeviceDefault.Widget.ActionBar.Title"/>

    <style name="HeaderTextAppearance" parent="@android:style/TextAppearance.DeviceDefault.Widget.ActionBar.Title"/>