diff --git a/res/values/cm_strings.xml b/res/values/cm_strings.xml
index ccb7f5dc58b768bfecef7a0302fe77caa13fe7f5..e2148f8077d93a9d5a0bd9727a008562e7591103 100644
--- a/res/values/cm_strings.xml
+++ b/res/values/cm_strings.xml
@@ -204,6 +204,9 @@
Sentry User ID
+
+ Quad9 DNS
+
Enable /e/OS Telemetry
Enable automatic bug reporting
@@ -217,8 +220,4 @@
This will erase all data from your tablet\u2019s internal storage, including:\n\nAll your account\nSystem and app data and settings\nDownloaded apps
This will erase all data from your phone\u2019s internal storage, including:\n\nAll your account\nSystem and app data and settings\nDownloaded apps
-
-
- Quad9
- dns.quad9.net
diff --git a/src/com/android/settings/network/PrivateDnsModeDialogPreference.java b/src/com/android/settings/network/PrivateDnsModeDialogPreference.java
index fe2a9edc25de920ab9a36e1e971a291d50811521..764bbd8d3e97dc98921ec1bc6121cb2475a5a3a5 100644
--- a/src/com/android/settings/network/PrivateDnsModeDialogPreference.java
+++ b/src/com/android/settings/network/PrivateDnsModeDialogPreference.java
@@ -17,6 +17,7 @@ package com.android.settings.network;
import static android.net.ConnectivityManager.PRIVATE_DNS_DEFAULT_MODE_FALLBACK;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OFF;
+import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_QUADNINE;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OPPORTUNISTIC;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_PROVIDER_HOSTNAME;
@@ -71,9 +72,6 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
// DNS_MODE -> RadioButton id
private static final Map PRIVATE_DNS_MAP;
- // Only used in Settings, update on additions to ConnectivitySettingsUtils
- private static final String PRIVATE_DNS_MODE_QUADNINE = "quadnine";
-
static {
PRIVATE_DNS_MAP = new HashMap<>();
PRIVATE_DNS_MAP.put(PRIVATE_DNS_MODE_OFF, R.id.private_dns_mode_off);
@@ -172,14 +170,6 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
final ContentResolver contentResolver = context.getContentResolver();
mMode = getModeFromSettings(context.getContentResolver());
- if (mMode == PRIVATE_DNS_MODE_PROVIDER_HOSTNAME) {
- final String privateDnsHostname = getHostnameFromSettings(contentResolver);
- final String quadNineHostname =
- context.getString(R.string.private_dns_hostname_quadnine);
- if (privateDnsHostname.equals(quadNineHostname)) {
- mMode = PRIVATE_DNS_MODE_QUADNINE;
- }
- }
mEditText = view.findViewById(R.id.private_dns_mode_provider_hostname);
mEditText.addTextChangedListener(this);
@@ -192,9 +182,9 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
// Initial radio button text
final RadioButton offRadioButton = view.findViewById(R.id.private_dns_mode_off);
offRadioButton.setText(R.string.private_dns_mode_off);
- final RadioButton quadNineRadioButton =
+ final RadioButton quadnineRadioButton =
view.findViewById(R.id.private_dns_mode_quadnine);
- quadNineRadioButton.setText(R.string.private_dns_mode_quadnine);
+ quadnineRadioButton.setText(R.string.private_dns_mode_quadnine);
final RadioButton opportunisticRadioButton =
view.findViewById(R.id.private_dns_mode_opportunistic);
opportunisticRadioButton.setText(R.string.private_dns_mode_opportunistic);
@@ -220,22 +210,15 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
public void onClick(DialogInterface dialog, int which) {
if (which == DialogInterface.BUTTON_POSITIVE) {
final Context context = getContext();
- String modeToSet = mMode;
if (mMode.equals(PRIVATE_DNS_MODE_PROVIDER_HOSTNAME)) {
// Only clickable if hostname is valid, so we could save it safely
Settings.Global.putString(context.getContentResolver(), HOSTNAME_KEY,
mEditText.getText().toString());
- } else if (mMode == PRIVATE_DNS_MODE_QUADNINE) {
- final String quadNineHostname =
- context.getString(R.string.private_dns_hostname_quadnine);
- Settings.Global.putString(context.getContentResolver(), HOSTNAME_KEY,
- quadNineHostname);
- modeToSet = PRIVATE_DNS_MODE_PROVIDER_HOSTNAME;
}
FeatureFactory.getFactory(context).getMetricsFeatureProvider().action(context,
- SettingsEnums.ACTION_PRIVATE_DNS_MODE, modeToSet);
- Settings.Global.putString(context.getContentResolver(), MODE_KEY, modeToSet);
+ SettingsEnums.ACTION_PRIVATE_DNS_MODE, mMode);
+ Settings.Global.putString(context.getContentResolver(), MODE_KEY, mMode);
}
}
diff --git a/src/com/android/settings/network/PrivateDnsPreferenceController.java b/src/com/android/settings/network/PrivateDnsPreferenceController.java
index e0222ba38916f8f16970538f4e13dd84c113e974..9c3396d012066c1dd8f46a3fa2ccddaf0187e3eb 100644
--- a/src/com/android/settings/network/PrivateDnsPreferenceController.java
+++ b/src/com/android/settings/network/PrivateDnsPreferenceController.java
@@ -17,6 +17,7 @@
package com.android.settings.network;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OFF;
+import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_QUADNINE;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_OPPORTUNISTIC;
import static android.net.ConnectivityManager.PRIVATE_DNS_MODE_PROVIDER_HOSTNAME;
import static android.provider.Settings.Global.PRIVATE_DNS_DEFAULT_MODE;
@@ -64,9 +65,6 @@ public class PrivateDnsPreferenceController extends BasePreferenceController
Settings.Global.getUriFor(PRIVATE_DNS_SPECIFIER),
};
- // Only used in Settings, update on additions to ConnectivitySettingsUtils
- private static final String PRIVATE_DNS_MODE_QUADNINE = "quadnine";
-
private final Handler mHandler;
private final ContentObserver mSettingsObserver;
private final ConnectivityManager mConnectivityManager;
@@ -132,21 +130,16 @@ public class PrivateDnsPreferenceController extends BasePreferenceController
case PRIVATE_DNS_MODE_OFF:
return res.getString(R.string.private_dns_mode_off);
case PRIVATE_DNS_MODE_QUADNINE:
+ return dnsesResolved
+ ? res.getString(R.string.private_dns_mode_quadnine)
+ : res.getString(R.string.private_dns_mode_provider_failure);
case PRIVATE_DNS_MODE_OPPORTUNISTIC:
return dnsesResolved ? res.getString(R.string.private_dns_mode_on)
: res.getString(R.string.private_dns_mode_opportunistic);
case PRIVATE_DNS_MODE_PROVIDER_HOSTNAME:
- if (!dnsesResolved) {
- return res.getString(R.string.private_dns_mode_provider_failure);
- }
- final String privateDnsHostname =
- PrivateDnsModeDialogPreference.getHostnameFromSettings(cr);
- final String quadNineHostname =
- res.getString(R.string.private_dns_hostname_quadnine);
- if (privateDnsHostname.equals(quadNineHostname)) {
- return res.getString(R.string.private_dns_mode_quadnine);
- }
- return privateDnsHostname;
+ return dnsesResolved
+ ? PrivateDnsModeDialogPreference.getHostnameFromSettings(cr)
+ : res.getString(R.string.private_dns_mode_provider_failure);
}
return "";
}