From ac543dfb0d0f2abe26fd509a68135a7bcb76d937 Mon Sep 17 00:00:00 2001 From: TheScarastic Date: Wed, 21 Sep 2022 07:17:01 +0000 Subject: [PATCH] Settings: Add support for more status in updater summary --- res/values/cm_strings.xml | 3 +++ .../SystemUpdatePreferenceController.java | 23 +++++++++---------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/res/values/cm_strings.xml b/res/values/cm_strings.xml index c4e7b528ea3..b625747b4e1 100644 --- a/res/values/cm_strings.xml +++ b/res/values/cm_strings.xml @@ -224,4 +224,7 @@ Updated to /e/OS v%1$s + /e/OS v%1$s - update available + /e/OS v%1$s - update in progress + /e/OS v%1$s - installed reboot required diff --git a/src/com/android/settings/system/SystemUpdatePreferenceController.java b/src/com/android/settings/system/SystemUpdatePreferenceController.java index c83c12b048e..f2727cbae4a 100644 --- a/src/com/android/settings/system/SystemUpdatePreferenceController.java +++ b/src/com/android/settings/system/SystemUpdatePreferenceController.java @@ -91,8 +91,8 @@ public class SystemUpdatePreferenceController extends BasePreferenceController { @Override public CharSequence getSummary() { - CharSequence summary = mContext.getString(R.string.e_version_summary, - SystemProperties.get(E_OS_VERSION_PROP)); + final String currentVersion = SystemProperties.get(E_OS_VERSION_PROP); + CharSequence summary = mContext.getString(R.string.e_version_summary, currentVersion); final FutureTask bundleFutureTask = new FutureTask<>( // Put the API call in a future to avoid StrictMode violation. () -> mUpdateManager.retrieveSystemUpdateInfo()); @@ -104,21 +104,20 @@ public class SystemUpdatePreferenceController extends BasePreferenceController { Log.w(TAG, "Error getting system update info."); return summary; } + + String version = updateInfo.getString(SystemUpdateManager.KEY_TITLE); switch (updateInfo.getInt(SystemUpdateManager.KEY_STATUS)) { case SystemUpdateManager.STATUS_WAITING_DOWNLOAD: + summary = mContext.getString(R.string.e_version_pending_update_summary, version); + break; case SystemUpdateManager.STATUS_IN_PROGRESS: - case SystemUpdateManager.STATUS_WAITING_INSTALL: + summary = mContext.getString(R.string.e_version_in_progress_update_summary, version); + break; case SystemUpdateManager.STATUS_WAITING_REBOOT: - summary = mContext.getText(R.string.android_version_pending_update_summary); + summary = mContext.getString(R.string.e_version_reboot_pending_summary, version); break; - case SystemUpdateManager.STATUS_UNKNOWN: - Log.d(TAG, "Update statue unknown"); - // fall through to next branch - case SystemUpdateManager.STATUS_IDLE: - final String version = updateInfo.getString(SystemUpdateManager.KEY_TITLE); - if (!TextUtils.isEmpty(version)) { - summary = mContext.getString(R.string.android_version_summary, version); - } + default: + summary = mContext.getString(R.string.e_version_summary, currentVersion); break; } return summary; -- GitLab