Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa7083c authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Shrink notification history views to fit 

If an app hasn't posted many notifications, don't show extra whitespace
after its notifications

Test: manual, look at apps that have posted 1-3 notifications, and 10+
Fixes: 199944158
Change-Id: I8ed3e25cd35956eae9ce2fc5677710a34200bdfc
parent ebe477db

res/layout/notification_history_app_layout.xml

+22 −8
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


<LinearLayout

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:app="http://schemas.android.com/apk/res-auto"

    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:orientation="vertical">
@@ -78,14 +79,27 @@ 
        android:layout_height="1dp"

        android:background="?android:attr/listDivider"/>



    <androidx.constraintlayout.widget.ConstraintLayout

        android:id="@+id/notification_list_wrapper"

        android:layout_width="match_parent"

        android:layout_height="wrap_content">



        <com.android.settings.notification.history.NotificationHistoryRecyclerView

        android:id="@+id/notification_list"

            android:layout_width="match_parent"

        android:layout_height="500dp"

            android:layout_height="wrap_content"

            android:id="@+id/notification_list"

            android:clipChildren="true"

            android:clipToPadding="true"

            android:clipToOutline="true"

            android:importantForAccessibility="yes"

        android:scrollbars="none"/>

            app:layout_constrainedHeight="true"

            app:layout_constraintHeight_min="48dp"

            app:layout_constraintHeight_max="500dp"

            app:layout_constraintTop_toTopOf="parent"

            app:layout_constraintEnd_toEndOf="parent"

            app:layout_constraintStart_toStartOf="parent"

            app:layout_constraintBottom_toBottomOf="parent"/>



    </androidx.constraintlayout.widget.ConstraintLayout>



</LinearLayout>
 
 No newline at end of file

src/com/android/settings/notification/history/NotificationHistoryActivity.java

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ public class NotificationHistoryActivity extends CollapsingToolbarBaseActivity { 
            View viewForPackage = LayoutInflater.from(this)

                    .inflate(R.layout.notification_history_app_layout, null);



            final View container = viewForPackage.findViewById(R.id.notification_list);

            final View container = viewForPackage.findViewById(R.id.notification_list_wrapper);

            container.setVisibility(View.GONE);

            View header = viewForPackage.findViewById(R.id.app_header);

            NotificationExpandButton expand = viewForPackage.findViewById(