Revert "Settings: Add Quad9 DNS as a private DNS provider" (fa06c40a) · Commits · e / os / android_packages_apps_Settings

res/layout/private_dns_mode_dialog.xml

+0 −8

Original line number	Diff line number	Diff line
		@@ -38,14 +38,6 @@
		android:layout_marginStart="8dp"
		android:minHeight="48dp"/>

		<RadioButton
		android:id="@+id/private_dns_mode_quadnine"
		android:text="@string/private_dns_mode_quadnine"
		android:layout_width="wrap_content"
		android:layout_height="wrap_content"
		android:layout_marginStart="8dp"
		android:minHeight="48dp"/>

		<RadioButton
		android:id="@+id/private_dns_mode_opportunistic"
		android:text="@string/private_dns_mode_opportunistic"

res/values/cm_strings.xml

+0 −4

Original line number	Diff line number	Diff line
		@@ -230,8 +230,4 @@
		<!-- Advanced Privacy -->
		<string name="advanced_privacy_dashboard_title" translatable="false">Advanced Privacy</string>
		<string name="advanced_privacy_dashboard_summary">Manage trackers, fake location, hide IP address</string>

		<!-- Private DNS -->
		<string name="private_dns_mode_quadnine" translatable="false">Quad9</string>
		<string name="private_dns_hostname_quadnine" translatable="false">dns.quad9.net</string>
		</resources>

src/com/android/settings/network/PrivateDnsModeDialogPreference.java

+2 −24

Original line number	Diff line number	Diff line
		@@ -70,13 +70,9 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
		// DNS_MODE -> RadioButton id
		private static final Map<String, Integer> PRIVATE_DNS_MAP;

		// Only used in Settings, update on additions to ConnectivitySettingsUtils
		private static final String PRIVATE_DNS_MODE_QUADNINE = "quadnine";

		static {
		PRIVATE_DNS_MAP = new HashMap<>();
		PRIVATE_DNS_MAP.put(PRIVATE_DNS_MODE_OFF, R.id.private_dns_mode_off);
		PRIVATE_DNS_MAP.put(PRIVATE_DNS_MODE_QUADNINE, R.id.private_dns_mode_quadnine);
		PRIVATE_DNS_MAP.put(PRIVATE_DNS_MODE_OPPORTUNISTIC, R.id.private_dns_mode_opportunistic);
		PRIVATE_DNS_MAP.put(PRIVATE_DNS_MODE_PROVIDER_HOSTNAME, R.id.private_dns_mode_provider);
		}
		@@ -171,14 +167,6 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
		final ContentResolver contentResolver = context.getContentResolver();

		mMode = getModeFromSettings(context.getContentResolver());
		if (mMode == PRIVATE_DNS_MODE_PROVIDER_HOSTNAME) {
		final String privateDnsHostname = getHostnameFromSettings(contentResolver);
		final String quadNineHostname =
		context.getString(R.string.private_dns_hostname_quadnine);
		if (privateDnsHostname.equals(quadNineHostname)) {
		mMode = PRIVATE_DNS_MODE_QUADNINE;
		}
		}

		mEditText = view.findViewById(R.id.private_dns_mode_provider_hostname);
		mEditText.addTextChangedListener(this);
		@@ -205,22 +193,15 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
		public void onClick(DialogInterface dialog, int which) {
		if (which == DialogInterface.BUTTON_POSITIVE) {
		final Context context = getContext();
		String modeToSet = mMode;
		if (mMode.equals(PRIVATE_DNS_MODE_PROVIDER_HOSTNAME)) {
		// Only clickable if hostname is valid, so we could save it safely
		Settings.Global.putString(context.getContentResolver(), HOSTNAME_KEY,
		mEditText.getText().toString());
		} else if (mMode == PRIVATE_DNS_MODE_QUADNINE) {
		final String quadNineHostname =
		context.getString(R.string.private_dns_hostname_quadnine);
		Settings.Global.putString(context.getContentResolver(), HOSTNAME_KEY,
		quadNineHostname);
		modeToSet = PRIVATE_DNS_MODE_PROVIDER_HOSTNAME;
		}

		FeatureFactory.getFactory(context).getMetricsFeatureProvider().action(context,
		SettingsEnums.ACTION_PRIVATE_DNS_MODE, modeToSet);
		Settings.Global.putString(context.getContentResolver(), MODE_KEY, modeToSet);
		SettingsEnums.ACTION_PRIVATE_DNS_MODE, mMode);
		Settings.Global.putString(context.getContentResolver(), MODE_KEY, mMode);
		}
		}

		@@ -230,9 +211,6 @@ public class PrivateDnsModeDialogPreference extends CustomDialogPreferenceCompat
		case R.id.private_dns_mode_off:
		mMode = PRIVATE_DNS_MODE_OFF;
		break;
		case R.id.private_dns_mode_quadnine:
		mMode = PRIVATE_DNS_MODE_QUADNINE;
		break;
		case R.id.private_dns_mode_opportunistic:
		mMode = PRIVATE_DNS_MODE_OPPORTUNISTIC;
		break;

src/com/android/settings/network/PrivateDnsPreferenceController.java

+3 −15

Original line number	Diff line number	Diff line
		@@ -64,9 +64,6 @@ public class PrivateDnsPreferenceController extends BasePreferenceController
		Settings.Global.getUriFor(PRIVATE_DNS_SPECIFIER),
		};

		// Only used in Settings, update on additions to ConnectivitySettingsUtils
		private static final String PRIVATE_DNS_MODE_QUADNINE = "quadnine";

		private final Handler mHandler;
		private final ContentObserver mSettingsObserver;
		private final ConnectivityManager mConnectivityManager;
		@@ -131,7 +128,6 @@ public class PrivateDnsPreferenceController extends BasePreferenceController
		switch (mode) {
		case PRIVATE_DNS_MODE_OFF:
		return res.getString(R.string.private_dns_mode_off);
		case PRIVATE_DNS_MODE_QUADNINE:
		case PRIVATE_DNS_MODE_OPPORTUNISTIC:
		// TODO (b/79122154) : create a string specifically for this, instead of
		// hijacking a string from notifications. This is necessary at this time
		@@ -140,17 +136,9 @@ public class PrivateDnsPreferenceController extends BasePreferenceController
		return dnsesResolved ? res.getString(R.string.switch_on_text)
		: res.getString(R.string.private_dns_mode_opportunistic);
		case PRIVATE_DNS_MODE_PROVIDER_HOSTNAME:
		if (!dnsesResolved) {
		return res.getString(R.string.private_dns_mode_provider_failure);
		}
		final String privateDnsHostname =
		PrivateDnsModeDialogPreference.getHostnameFromSettings(cr);
		final String quadNineHostname =
		res.getString(R.string.private_dns_hostname_quadnine);
		if (privateDnsHostname.equals(quadNineHostname)) {
		return res.getString(R.string.private_dns_mode_quadnine);
		}
		return privateDnsHostname;
		return dnsesResolved
		? PrivateDnsModeDialogPreference.getHostnameFromSettings(cr)
		: res.getString(R.string.private_dns_mode_provider_failure);
		}
		return "";
		}