Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9e985d0 authored by Fan Zhang's avatar Fan Zhang
Browse files

Enable suggestion v2 experiment 

Bug: 68662574
Test: robotests
Change-Id: Ib8aeef45ebe1260e9c8699e231db37840a0ce3db
parent 10d0518f

src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ public class SuggestionFeatureProviderImpl implements SuggestionFeatureProvider 
    }



    private static boolean isV2Enabled() {

        return FeatureFlagUtils.isEnabled(FEATURE_FLAG_SUGGESTIONS_V2);

        return FeatureFlagUtils.isEnabled(FEATURE_FLAG_SUGGESTIONS_V2) || true;

    }



    @Override

tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java

+0 −15
Original line number Diff line number Diff line
@@ -132,13 +132,6 @@ public class SuggestionFeatureProviderImplTest { 
        assertThat(mProvider.isSuggestionEnabled(mContext)).isFalse();

    }



    @Test

    public void isSuggestionEnabled_isNotLowMemoryDevice_shouldReturnTrue() {

        when(mActivityManager.isLowRamDevice()).thenReturn(false);



        assertThat(mProvider.isSuggestionEnabled(mContext)).isTrue();

    }



    @Test

    public void isSuggestionV2Enabled_isNotLowMemoryDevice_sysPropOn_shouldReturnTrue() {

        when(mActivityManager.isLowRamDevice()).thenReturn(false);
@@ -147,14 +140,6 @@ public class SuggestionFeatureProviderImplTest { 
        assertThat(mProvider.isSuggestionV2Enabled(mContext)).isTrue();

    }



    @Test

    public void isSuggestionV2Enabled_isNotLowMemoryDevice_sysPropOff_shouldReturnTrue() {

        when(mActivityManager.isLowRamDevice()).thenReturn(false);

        SettingsShadowSystemProperties.set(

                FeatureFlagUtils.FFLAG_PREFIX + mProvider.FEATURE_FLAG_SUGGESTIONS_V2, "false");

        assertThat(mProvider.isSuggestionV2Enabled(mContext)).isFalse();

    }



    @Test

    public void dismissSuggestion_noParserOrSuggestion_noop() {

        mProvider.dismissSuggestion(mContext, null, (Tile) null);