Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6979e25 authored by jackqdyulei's avatar jackqdyulei
Browse files

update summary change no matter whether summary is equal 

Since the method parameter tile and tile in adpater is the same
instance, it is useless to check whether summary has changed.

Test: Run SettingsRoboTests
The function used in notifySummaryChanged already has testcases
in DashboardDataTest

Change-Id: I8c8969fcd2c89f368ca507808910fc7a9852f192
parent 301fe80f

src/com/android/settings/dashboard/DashboardAdapter.java

+3 −7
Original line number Diff line number Diff line
@@ -163,15 +163,11 @@ public class DashboardAdapter extends RecyclerView.Adapter<DashboardAdapter.Dash 
    public void notifySummaryChanged(Tile tile) {

        final int position = mDashboardData.getPositionByTile(tile);

        if (position != DashboardData.POSITION_NOT_FOUND) {

            final Tile targetTile = (Tile) mDashboardData.getItemEntityByPosition(position);

            if (!TextUtils.equals(tile.summary, targetTile.summary)) {



            // Since usually tile in parameter and tile in mCategories are same instance,

            // which is hard to be detected by DiffUtil, so we notifyItemChanged directly.

            notifyItemChanged(position);

        }

    }

    }



    // TODO: move this method to SuggestionParser or some other util class

    public void disableSuggestion(Tile suggestion) {