Merge changes from topic "anomaly_metric_update" (f12dbf93) · Commits · e / os / android_packages_apps_Settings

src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java

+4 −0

Original line number	Diff line number	Diff line
		@@ -45,6 +45,7 @@ import com.android.settings.SettingsActivity;
		import com.android.settings.Utils;
		import com.android.settings.applications.LayoutPreference;
		import com.android.settings.dashboard.DashboardFragment;
		import com.android.settings.fuelgauge.anomaly.AnomalyUtils;
		import com.android.settings.wrapper.DevicePolicyManagerWrapper;
		import com.android.settings.fuelgauge.anomaly.Anomaly;
		import com.android.settings.fuelgauge.anomaly.AnomalyDialogFragment;
		@@ -360,6 +361,9 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements

		@Override
		public void onLoadFinished(Loader<List<Anomaly>> loader, List<Anomaly> data) {
		final AnomalyUtils anomalyUtils = AnomalyUtils.getInstance(getContext());
		anomalyUtils.logAnomalies(mMetricsFeatureProvider, data,
		MetricsEvent.FUELGAUGE_POWER_USAGE_DETAIL);
		mAnomalySummaryPreferenceController.updateAnomalySummaryPreference(data);
		}

src/com/android/settings/fuelgauge/PowerUsageAnomalyDetails.java

+1 −2

Original line number	Diff line number	Diff line
		@@ -125,8 +125,7 @@ public class PowerUsageAnomalyDetails extends DashboardFragment implements

		@Override
		public int getMetricsCategory() {
		//TODO(b/37681923): add correct metrics category
		return 0;
		return MetricsProto.MetricsEvent.FUELGAUGE_ANOMALY_DETAIL;
		}

		void refreshUi() {

src/com/android/settings/fuelgauge/PowerUsageSummary.java

+5 −0

Original line number	Diff line number	Diff line
		@@ -67,6 +67,7 @@ import com.android.settings.fuelgauge.anomaly.AnomalyDetectionPolicy;
		import com.android.settings.fuelgauge.anomaly.AnomalyDialogFragment.AnomalyDialogListener;
		import com.android.settings.fuelgauge.anomaly.AnomalyLoader;
		import com.android.settings.fuelgauge.anomaly.AnomalySummaryPreferenceController;
		import com.android.settings.fuelgauge.anomaly.AnomalyUtils;
		import com.android.settings.overlay.FeatureFactory;
		import com.android.settings.search.BaseSearchIndexProvider;
		import com.android.settingslib.core.AbstractPreferenceController;
		@@ -148,6 +149,10 @@ public class PowerUsageSummary extends PowerUsageBase implements

		@Override
		public void onLoadFinished(Loader<List<Anomaly>> loader, List<Anomaly> data) {
		final AnomalyUtils anomalyUtils = AnomalyUtils.getInstance(getContext());
		anomalyUtils.logAnomalies(mMetricsFeatureProvider, data,
		MetricsEvent.FUELGAUGE_POWER_USAGE_SUMMARY);

		// show high usage preference if possible
		mAnomalySummaryPreferenceController.updateAnomalySummaryPreference(data);

src/com/android/settings/fuelgauge/anomaly/AnomalyDialogFragment.java

+7 −3

Original line number	Diff line number	Diff line
		@@ -23,6 +23,7 @@ import android.content.DialogInterface;
		import android.os.Bundle;
		import android.support.annotation.VisibleForTesting;

		import com.android.internal.logging.nano.MetricsProto;
		import com.android.settings.R;
		import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
		import com.android.settings.fuelgauge.anomaly.action.AnomalyAction;
		@@ -79,8 +80,7 @@ public class AnomalyDialogFragment extends InstrumentedDialogFragment implements

		@Override
		public int getMetricsCategory() {
		// TODO(b/37681923): add anomaly metric id
		return 0;
		return MetricsProto.MetricsEvent.DIALOG_HANDLE_ANOMALY;
		}

		@Override
		@@ -100,9 +100,13 @@ public class AnomalyDialogFragment extends InstrumentedDialogFragment implements
		@Override
		public Dialog onCreateDialog(Bundle savedInstanceState) {
		final Bundle bundle = getArguments();
		final Context context = getContext();
		final AnomalyUtils anomalyUtils = AnomalyUtils.getInstance(context);

		mAnomaly = bundle.getParcelable(ARG_ANOMALY);
		anomalyUtils.logAnomaly(mMetricsFeatureProvider, mAnomaly,
		MetricsProto.MetricsEvent.DIALOG_HANDLE_ANOMALY);

		final Context context = getContext();
		final AnomalyAction anomalyAction = mAnomalyUtils.getAnomalyAction(mAnomaly);
		switch (anomalyAction.getActionType()) {
		case Anomaly.AnomalyActionType.FORCE_STOP:

src/com/android/settings/fuelgauge/anomaly/AnomalyUtils.java

+50 −0

Original line number	Diff line number	Diff line
		@@ -19,8 +19,12 @@ package com.android.settings.fuelgauge.anomaly;
		import android.content.Context;
		import android.os.Build;
		import android.support.annotation.VisibleForTesting;
		import android.util.Pair;
		import android.util.SparseIntArray;

		import com.android.internal.logging.nano.MetricsProto;
		import com.android.internal.os.BatteryStatsHelper;
		import com.android.settings.core.instrumentation.MetricsFeatureProvider;
		import com.android.settings.fuelgauge.anomaly.action.AnomalyAction;
		import com.android.settings.fuelgauge.anomaly.action.ForceStopAction;
		import com.android.settings.fuelgauge.anomaly.action.LocationCheckAction;
		@@ -40,6 +44,17 @@ public class AnomalyUtils {
		private Context mContext;
		private static AnomalyUtils sInstance;

		private static final SparseIntArray mMetricArray;
		static {
		mMetricArray = new SparseIntArray();
		mMetricArray.append(Anomaly.AnomalyType.WAKE_LOCK,
		MetricsProto.MetricsEvent.ANOMALY_TYPE_WAKELOCK);
		mMetricArray.append(Anomaly.AnomalyType.WAKEUP_ALARM,
		MetricsProto.MetricsEvent.ANOMALY_TYPE_WAKEUP_ALARM);
		mMetricArray.append(Anomaly.AnomalyType.BLUETOOTH_SCAN,
		MetricsProto.MetricsEvent.ANOMALY_TYPE_UNOPTIMIZED_BT);
		}

		@VisibleForTesting
		AnomalyUtils(Context context) {
		mContext = context.getApplicationContext();
		@@ -118,4 +133,39 @@ public class AnomalyUtils {
		return anomalies;
		}

		/**
		* Log the list of {@link Anomaly} using {@link MetricsFeatureProvider}, which contains
		* anomaly type, package name, field_context, field_action_type
		*
		* @param provider provider to do the logging
		* @param anomalies contains the data to log
		* @param contextId which page invoke this logging
		* @see #logAnomaly(MetricsFeatureProvider, Anomaly, int)
		*/
		public void logAnomalies(MetricsFeatureProvider provider, List<Anomaly> anomalies,
		int contextId) {
		for (int i = 0, size = anomalies.size(); i < size; i++) {
		logAnomaly(provider, anomalies.get(i), contextId);
		}
		}

		/**
		* Log the {@link Anomaly} using {@link MetricsFeatureProvider}, which contains
		* anomaly type, package name, field_context, field_action_type
		*
		* @param provider provider to do the logging
		* @param anomaly contains the data to log
		* @param contextId which page invoke this logging
		* @see #logAnomalies(MetricsFeatureProvider, List, int)
		*/
		public void logAnomaly(MetricsFeatureProvider provider, Anomaly anomaly, int contextId) {
		provider.action(
		mContext,
		mMetricArray.get(anomaly.type, MetricsProto.MetricsEvent.VIEW_UNKNOWN),
		anomaly.packageName,
		Pair.create(MetricsProto.MetricsEvent.FIELD_CONTEXT, contextId),
		Pair.create(MetricsProto.MetricsEvent.FIELD_ANOMALY_ACTION_TYPE,
		getAnomalyAction(anomaly).getActionType()));
		}

		}