Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecb39532 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Password settings: Fix UI flicker from loading summary" into sc-dev am: d60eae55 

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15136527

Change-Id: I59bfe1ed8f2aadff961192f24fa678a12b50c297
parents 9850707a d60eae55

src/com/android/settings/applications/autofill/PasswordsPreferenceController.java

+10 −4
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ import java.util.concurrent.atomic.AtomicBoolean; 
public class PasswordsPreferenceController extends BasePreferenceController

        implements LifecycleObserver {

    private static final String TAG = "AutofillSettings";

    private static final boolean DEBUG = false;



    private final PackageManager mPm;

    private final IconDrawableFactory mIconFactory;
@@ -128,6 +129,8 @@ public class PasswordsPreferenceController extends BasePreferenceController 
            pref.setIntent(

                    new Intent(Intent.ACTION_MAIN)

                            .setClassName(serviceInfo.packageName, service.getPasswordsActivity()));

            // Set an empty summary to avoid a UI flicker when the value loads.

            pref.setSummary(R.string.summary_placeholder);



            final MutableLiveData<Integer> passwordCount = new MutableLiveData<>();

            passwordCount.observe(
@@ -172,15 +175,18 @@ public class PasswordsPreferenceController extends BasePreferenceController 
        @Override

        public void onServiceConnected(ComponentName name, IBinder service) {

            final IAutoFillService autofillService = IAutoFillService.Stub.asInterface(service);

            // TODO check if debug is logged on user build.

            if (DEBUG) {

                Log.d(TAG, "Fetching password count from " + name);

            }

            try {

                autofillService.onSavedPasswordCountRequest(

                        new IResultReceiver.Stub() {

                            @Override

                            public void send(int resultCode, Bundle resultData) {

                                if (DEBUG) {

                                    Log.d(TAG, "Received password count result " + resultCode

                                            + " from " + name);

                                }

                                if (resultCode == 0 && resultData != null) {

                                    mData.postValue(resultData.getInt(EXTRA_RESULT));

                                }