Merge "Do not retrive app detail if the fragment is exiting." into qt-dev (dda677cf) · Commits · e / os / android_packages_apps_Settings

src/com/android/settings/applications/appinfo/AppInfoDashboardFragment.java

+4 −3

Original line number	Diff line number	Diff line
		@@ -112,7 +112,8 @@ public class AppInfoDashboardFragment extends DashboardFragment
		private UserManager mUserManager;
		private PackageManager mPm;

		private boolean mFinishing;
		@VisibleForTesting
		boolean mFinishing;
		private boolean mListeningToPackageRemove;


		@@ -544,7 +545,7 @@ public class AppInfoDashboardFragment extends DashboardFragment
		@VisibleForTesting
		void retrieveAppEntry() {
		final Activity activity = getActivity();
		if (activity == null) {
		if (activity == null \|\| mFinishing) {
		return;
		}
		if (mState == null) {

+7 −0

Original line number	Diff line number	Diff line
		@@ -281,6 +281,13 @@ public final class AppInfoDashboardFragmentTest {
		assertThat(mFragment.createPreferenceControllers(mShadowContext)).isNull();
		}

		@Test
		public void getPreferenceControllers_exiting_shouldReturnNull() {
		mFragment.mFinishing = true;

		assertThat(mFragment.createPreferenceControllers(mShadowContext)).isNull();
		}

		@Test
		public void getNumberOfUserWithPackageInstalled_twoUsersInstalled_shouldReturnTwo()
		throws PackageManager.NameNotFoundException {