Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d72c062f authored by Wink Saville's avatar Wink Saville
Browse files

Change tests against INVALID_SUBSCRIPTION_ID to use isValidSubscriptionId. 

Bug: 18668873
Change-Id: Ie709a62bbb74e0a767daeb9e3fb3aecd4c45df44
parent 25a1181f

src/com/android/settings/DataUsageSummary.java

+1 −1
Original line number Diff line number Diff line
@@ -2285,7 +2285,7 @@ public class DataUsageSummary extends HighlightingFragment implements Indexable 
        if (template == null) {

            final int subId = intent.getIntExtra(PhoneConstants.SUBSCRIPTION_KEY,

                    SubscriptionManager.INVALID_SUBSCRIPTION_ID);

            if (SubscriptionManager.isValidSubId(subId)) {

            if (SubscriptionManager.isValidSubscriptionId(subId)) {

                return TAB_MOBILE + String.valueOf(subId);

            }

            return null;

src/com/android/settings/deviceinfo/SimStatus.java

+1 −1
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ public class SimStatus extends PreferenceActivity { 
            final Phone phone = PhoneFactory.getPhone(SubscriptionManager.getPhoneId(

                        mSir.getSubscriptionId()));

            if (UserHandle.myUserId() == UserHandle.USER_OWNER

                    && mSir.getSubscriptionId() != SubscriptionManager.INVALID_SUBSCRIPTION_ID) {

                    && SubscriptionManager.isValidSubscriptionId(mSir.getSubscriptionId())) {

                if (phone == null) {

                    Log.e(TAG, "Unable to locate a phone object for the given Subscription ID.");

                    return;