Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3b0c37e authored by Meng Wang's avatar Meng Wang
Browse files

WiFiCallingSettings: don't start carrier app in onResume 

onResume initialize UI before registering switch change listener.
So that listener is not invoked in UI initialization, but only real
switch change by user.

Bug: 33680334
Test: make
Test: manual - carrier app is not invoked in onResume
Change-Id: I7ca1eb1eab214b50c8de72946590c1ecb676d4df
parent 6f743758

src/com/android/settings/WifiCallingSettings.java

+9 −9
Original line number Diff line number Diff line
@@ -253,15 +253,6 @@ public class WifiCallingSettings extends SettingsPreferenceFragment 


        final Context context = getActivity();



        if (ImsManager.isWfcEnabledByPlatform(context)) {

            TelephonyManager tm = (TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE);

            tm.listen(mPhoneStateListener, PhoneStateListener.LISTEN_CALL_STATE);



            mSwitchBar.addOnSwitchChangeListener(this);



            mValidListener = true;

        }



        // NOTE: Buttons will be enabled/disabled in mPhoneStateListener

        boolean wfcEnabled = ImsManager.isWfcEnabledByUser(context)

                && ImsManager.isNonTtyOrTtyOnVolteEnabled(context);
@@ -272,6 +263,15 @@ public class WifiCallingSettings extends SettingsPreferenceFragment 
        mButtonWfcRoamingMode.setValue(Integer.toString(wfcRoamingMode));

        updateButtonWfcMode(context, wfcEnabled, wfcMode, wfcRoamingMode);



        if (ImsManager.isWfcEnabledByPlatform(context)) {

            TelephonyManager tm = (TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE);

            tm.listen(mPhoneStateListener, PhoneStateListener.LISTEN_CALL_STATE);



            mSwitchBar.addOnSwitchChangeListener(this);



            mValidListener = true;

        }



        context.registerReceiver(mIntentReceiver, mIntentFilter);



        Intent intent = getActivity().getIntent();