Loading src/com/android/settings/display/BrightnessLevelPreferenceController.java +19 −12 Original line number Original line Diff line number Diff line Loading @@ -13,6 +13,9 @@ */ */ package com.android.settings.display; package com.android.settings.display; import static com.android.settingslib.display.BrightnessUtils.GAMMA_SPACE_MAX; import static com.android.settingslib.display.BrightnessUtils.convertLinearToGamma; import android.content.ContentResolver; import android.content.ContentResolver; import android.content.Context; import android.content.Context; import android.database.ContentObserver; import android.database.ContentObserver; Loading Loading @@ -103,6 +106,7 @@ public class BrightnessLevelPreferenceController extends AbstractPreferenceContr public void updateState(Preference preference) { public void updateState(Preference preference) { updatedSummary(preference); updatedSummary(preference); } } @Override @Override public void onStart() { public void onStart() { mContentResolver.registerContentObserver(BRIGHTNESS_URI, false, mBrightnessObserver); mContentResolver.registerContentObserver(BRIGHTNESS_URI, false, mBrightnessObserver); Loading @@ -122,15 +126,18 @@ public class BrightnessLevelPreferenceController extends AbstractPreferenceContr } } private double getCurrentBrightness() { private double getCurrentBrightness() { final int value; if (isInVrMode()) { if (isInVrMode()) { final double value = System.getInt(mContentResolver, System.SCREEN_BRIGHTNESS_FOR_VR, value = convertLinearToGamma(System.getInt(mContentResolver, mMaxBrightness); System.SCREEN_BRIGHTNESS_FOR_VR, mMaxBrightness), return getPercentage(value, mMinVrBrightness, mMaxVrBrightness); mMinVrBrightness, mMaxVrBrightness); } else { } else { final double value = Settings.System.getInt(mContentResolver, System.SCREEN_BRIGHTNESS, value = convertLinearToGamma(Settings.System.getInt(mContentResolver, mMinBrightness); System.SCREEN_BRIGHTNESS, mMinBrightness), return getPercentage(value, mMinBrightness, mMaxBrightness); mMinBrightness, mMaxBrightness); } } return getPercentage(value, 0, GAMMA_SPACE_MAX); } } private double getPercentage(double value, int min, int max) { private double getPercentage(double value, int min, int max) { Loading tests/robotests/src/com/android/settings/display/BrightnessLevelPreferenceControllerTest.java +3 −3 Original line number Original line Diff line number Diff line Loading @@ -122,7 +122,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("85%"); verify(mPreference).setSummary("97%"); } } @Test @Test Loading @@ -135,7 +135,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("31%"); verify(mPreference).setSummary("78%"); } } @Test @Test Loading @@ -148,7 +148,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("45%"); verify(mPreference).setSummary("85%"); } } @Test @Test Loading Loading
src/com/android/settings/display/BrightnessLevelPreferenceController.java +19 −12 Original line number Original line Diff line number Diff line Loading @@ -13,6 +13,9 @@ */ */ package com.android.settings.display; package com.android.settings.display; import static com.android.settingslib.display.BrightnessUtils.GAMMA_SPACE_MAX; import static com.android.settingslib.display.BrightnessUtils.convertLinearToGamma; import android.content.ContentResolver; import android.content.ContentResolver; import android.content.Context; import android.content.Context; import android.database.ContentObserver; import android.database.ContentObserver; Loading Loading @@ -103,6 +106,7 @@ public class BrightnessLevelPreferenceController extends AbstractPreferenceContr public void updateState(Preference preference) { public void updateState(Preference preference) { updatedSummary(preference); updatedSummary(preference); } } @Override @Override public void onStart() { public void onStart() { mContentResolver.registerContentObserver(BRIGHTNESS_URI, false, mBrightnessObserver); mContentResolver.registerContentObserver(BRIGHTNESS_URI, false, mBrightnessObserver); Loading @@ -122,15 +126,18 @@ public class BrightnessLevelPreferenceController extends AbstractPreferenceContr } } private double getCurrentBrightness() { private double getCurrentBrightness() { final int value; if (isInVrMode()) { if (isInVrMode()) { final double value = System.getInt(mContentResolver, System.SCREEN_BRIGHTNESS_FOR_VR, value = convertLinearToGamma(System.getInt(mContentResolver, mMaxBrightness); System.SCREEN_BRIGHTNESS_FOR_VR, mMaxBrightness), return getPercentage(value, mMinVrBrightness, mMaxVrBrightness); mMinVrBrightness, mMaxVrBrightness); } else { } else { final double value = Settings.System.getInt(mContentResolver, System.SCREEN_BRIGHTNESS, value = convertLinearToGamma(Settings.System.getInt(mContentResolver, mMinBrightness); System.SCREEN_BRIGHTNESS, mMinBrightness), return getPercentage(value, mMinBrightness, mMaxBrightness); mMinBrightness, mMaxBrightness); } } return getPercentage(value, 0, GAMMA_SPACE_MAX); } } private double getPercentage(double value, int min, int max) { private double getPercentage(double value, int min, int max) { Loading
tests/robotests/src/com/android/settings/display/BrightnessLevelPreferenceControllerTest.java +3 −3 Original line number Original line Diff line number Diff line Loading @@ -122,7 +122,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("85%"); verify(mPreference).setSummary("97%"); } } @Test @Test Loading @@ -135,7 +135,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("31%"); verify(mPreference).setSummary("78%"); } } @Test @Test Loading @@ -148,7 +148,7 @@ public class BrightnessLevelPreferenceControllerTest { mController.updateState(mPreference); mController.updateState(mPreference); verify(mPreference).setSummary("45%"); verify(mPreference).setSummary("85%"); } } @Test @Test Loading