Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5c84f5b authored by mxyyiyi's avatar mxyyiyi
Browse files

[Expressive Battery] Initializes message preference when tip type change 

- The button visible and clicklistener will restore when tip type update, so forcely clean up.

Bug: 31802502
Test: atest BatteryTipPreferenceControllerTest BatteryDefenderTipTest BatteryTipTest IncompatibleChargerTipTest LowBatteryTipTest BatteryHealthTipTest
Test: atest DockDefenderTipTest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: Iffbf96205ebbe925b2a281f67867328eda0fcddf
parent 3c8e4222

src/com/android/settings/fuelgauge/batterytip/tips/BatteryTip.java

+5 −0
Original line number Diff line number Diff line
@@ -170,7 +170,12 @@ public abstract class BatteryTip implements Comparable<BatteryTip>, Parcelable { 
        final BannerMessagePreference cardPreference =

                castToBannerMassagePreferenceSafely(preference);

        if (cardPreference != null) {

            // Initializes message preference when tip type change

            cardPreference.setAttentionLevel(AttentionLevel.NORMAL);

            cardPreference.setDismissButtonVisible(false);

            cardPreference.setPositiveButtonVisible(false);

            cardPreference.setNegativeButtonVisible(false);

            cardPreference.setOnPreferenceClickListener(null);

        }

    }

tests/robotests/src/com/android/settings/fuelgauge/batterytip/tips/BatteryDefenderTipTest.java

+3 −1
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ import static com.google.common.truth.Truth.assertThat; 


import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.spy;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;

import static org.mockito.Mockito.when;
@@ -151,7 +152,8 @@ public class BatteryDefenderTipTest { 
    public void updatePreference_whenNotCharging_SetPositiveButtonVisibleToBeFalse() {

        mBatteryDefenderTip.updatePreference(mCardPreference);



        verify(mCardPreference).setPositiveButtonVisible(false);

        // Once for init, once for update

        verify(mCardPreference, times(2)).setPositiveButtonVisible(false);

    }



    private String getLastErrorLog() {