Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4cbe4ec authored by menghanli's avatar menghanli Committed by Jason Hsu
Browse files

Fix “Select to Speak & TalkBack ” Functionalities broken from Vision Settings.

getArguments() order to cause the mToggleServiceDividerSwitchPreference is null.

Bug: 149663592
Test: Manual test
Change-Id: I2d4a229f9386cf5c223056b39174c0e4bd891bdc
parent 66a301bb
Loading
Loading
Loading
Loading
+3 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settings.accessibility;

import android.app.settings.SettingsEnums;
import android.os.Bundle;
import android.view.View;

/** For accessibility services that target SDK <= Q in setup wizard. */
public class LegacyToggleScreenReaderPreferenceFragmentForSetupWizard
@@ -26,8 +27,8 @@ public class LegacyToggleScreenReaderPreferenceFragmentForSetupWizard
    private boolean mToggleSwitchWasInitiallyChecked;

    @Override
    protected void onProcessArguments(Bundle arguments) {
        super.onProcessArguments(arguments);
    public void onViewCreated(View view, Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);
        mToggleSwitchWasInitiallyChecked = mToggleServiceDividerSwitchPreference.isChecked();
    }

+3 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settings.accessibility;

import android.app.settings.SettingsEnums;
import android.os.Bundle;
import android.view.View;

/** For accessibility services that target SDK <= Q in setup wizard. */
public class LegacyToggleSelectToSpeakPreferenceFragmentForSetupWizard
@@ -26,8 +27,8 @@ public class LegacyToggleSelectToSpeakPreferenceFragmentForSetupWizard
    private boolean mToggleSwitchWasInitiallyChecked;

    @Override
    protected void onProcessArguments(Bundle arguments) {
        super.onProcessArguments(arguments);
    public void onViewCreated(View view, Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);
        mToggleSwitchWasInitiallyChecked = mToggleServiceDividerSwitchPreference.isChecked();
    }

+3 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settings.accessibility;

import android.app.settings.SettingsEnums;
import android.os.Bundle;
import android.view.View;

public class ToggleScreenReaderPreferenceFragmentForSetupWizard
        extends ToggleAccessibilityServicePreferenceFragment {
@@ -25,8 +26,8 @@ public class ToggleScreenReaderPreferenceFragmentForSetupWizard
    private boolean mToggleSwitchWasInitiallyChecked;

    @Override
    protected void onProcessArguments(Bundle arguments) {
        super.onProcessArguments(arguments);
    public void onViewCreated(View view, Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);
        mToggleSwitchWasInitiallyChecked = mToggleServiceDividerSwitchPreference.isChecked();
    }

+3 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settings.accessibility;

import android.app.settings.SettingsEnums;
import android.os.Bundle;
import android.view.View;

public class ToggleSelectToSpeakPreferenceFragmentForSetupWizard
        extends InvisibleToggleAccessibilityServicePreferenceFragment {
@@ -25,8 +26,8 @@ public class ToggleSelectToSpeakPreferenceFragmentForSetupWizard
    private boolean mToggleSwitchWasInitiallyChecked;

    @Override
    protected void onProcessArguments(Bundle arguments) {
        super.onProcessArguments(arguments);
    public void onViewCreated(View view, Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);
        mToggleSwitchWasInitiallyChecked = mToggleServiceDividerSwitchPreference.isChecked();
    }