Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2c27227 authored by Hakjun Choi's avatar Hakjun Choi
Browse files

Hide extra information link when it is empty 

Extra information may be or may not be provided as this is given from the Carriers, therefore it is needed to hide when there is no given URL string

Bug: 360265682
Flag: EXEMPT bugfix
Test: manually test when extra information is valid and when extra information is empty
      https://b.corp.google.com/issues/360265682#comment2 for UI test
result

Change-Id: Icf7f06e6af8580d0e84382a2598be75e321cf657
parent 5087754b

src/com/android/settings/network/telephony/SatelliteSetting.java

+12 −12
Original line number Diff line number Diff line
@@ -195,6 +195,7 @@ public class SatelliteSetting extends RestrictedDashboardFragment { 


            final String[] link = new String[1];

            link[0] = readSatelliteMoreInfoString(mSubId);

            if (link[0] != null && !link[0].isEmpty()) {

                footerPreference.setLearnMoreAction(view -> {

                    if (!link[0].isEmpty()) {

                        Intent helpIntent = HelpUtils.getHelpIntent(mActivity, link[0],
@@ -206,8 +207,7 @@ public class SatelliteSetting extends RestrictedDashboardFragment { 
                });

                footerPreference.setLearnMoreText(

                        getResources().getString(R.string.more_about_satellite_messaging));



            // TODO : b/320467418 add rounded rectangle border line to footer preference.

            }

        }

    }