Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b71efad6 authored by Amith Yamasani's avatar Amith Yamasani
Browse files

Potential fix for NPE in Running services. 

Bug: 5698270

Loop was removing items from the list being iterated.

Change-Id: I39e98c554b2fe6024381afbe79b737b812e78f08
parent e9b79e3a

src/com/android/settings/applications/RunningState.java

+3 −1
Original line number Diff line number Diff line
@@ -815,7 +815,7 @@ public class RunningState { 
        // Build the chains from client processes to the process they are

        // dependent on; also remove any old running processes.

        int NRP = mRunningProcesses.size();

        for (int i=0; i<NRP; i++) {

        for (int i = 0; i < NRP;) {

            ProcessItem proc = mRunningProcesses.valueAt(i);

            if (proc.mRunningSeq == mSequence) {

                int clientPid = proc.mRunningProcessInfo.importanceReasonPid;
@@ -833,9 +833,11 @@ public class RunningState { 
                    // we will detect the change.

                    proc.mClient = null;

                }

                i++;

            } else {

                changed = true;

                mRunningProcesses.remove(mRunningProcesses.keyAt(i));

                NRP--;

            }

        }