Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3fb8e01 authored by Roy Chou's avatar Roy Chou
Browse files

chore(text reading settings): increase preview block left/right padding when... 

chore(text reading settings): increase preview block left/right padding when landscape mode for easier scrolling

When the device is in landscape mode, In the text reading preference page, users have difficulty scrolling the RecyclerView because the preview block is almost full-screen. To scroll the preference list, users typically try to pan the preview block, but the block consumes the scroll gesture, preventing the list from scrolling. Users can successfully scroll the list content by panning outside the preview block. As a quick workaround, we increase the left/right padding of the preview block for landscape mode to make it easier for users to pan outside the block and scroll the preference list.

Bug: 301683714
Flag: NA
Test: manually - attach screenshot in bug
Change-Id: I1dba6e4d83ee1cd2f30163de05dfd7b42f829e42
parent d11b9d16

res/layout/accessibility_text_reading_preview.xml

+4 −3
Original line number Diff line number Diff line
@@ -19,8 +19,8 @@ 
    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:paddingVertical="@dimen/settingslib_illustration_padding"

    android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

    android:paddingStart="?android:attr/listPreferredItemPaddingStart">

    android:paddingEnd="@dimen/text_reading_preview_padding_end"

    android:paddingStart="@dimen/text_reading_preview_padding_start">



    <LinearLayout

        android:layout_width="match_parent"
@@ -28,7 +28,8 @@ 
        android:background="@drawable/accessibility_text_reading_preview"

        android:clipChildren="true"

        android:orientation="vertical"

        android:padding="18dp">

        android:paddingVertical="@dimen/text_reading_preview_background_padding_vertical"

        android:paddingHorizontal="@dimen/text_reading_preview_background_padding_horizontal">



        <TextView

            android:id="@+id/preview_label"

res/values-land/dimens.xml

+5 −0
Original line number Diff line number Diff line
@@ -20,4 +20,9 @@ 
    <dimen name="biometric_auth_pattern_view_max_size">348dp</dimen>



    <dimen name="notif_channel_panel_max_height">300dp</dimen>



    <!-- Text Reading Settings -->

    <dimen name="text_reading_preview_padding_start">64dp</dimen>

    <dimen name="text_reading_preview_padding_end">64dp</dimen>

    <dimen name="text_reading_preview_background_padding_horizontal">72dp</dimen>

</resources>

res/values/dimens.xml

+6 −0
Original line number Diff line number Diff line
@@ -226,6 +226,12 @@ 
    <dimen name="message_metadata_top_padding">4dp</dimen>

    <dimen name="message_icon_inset">11dp</dimen>



    <!-- Text Reading Settings -->

    <dimen name="text_reading_preview_padding_start">@*android:dimen/list_item_padding_end_material</dimen>

    <dimen name="text_reading_preview_padding_end">@*android:dimen/list_item_padding_end_material</dimen>

    <dimen name="text_reading_preview_background_padding_vertical">18dp</dimen>

    <dimen name="text_reading_preview_background_padding_horizontal">18dp</dimen>



    <!-- Accessibility Settings -->

    <dimen name="accessibility_layout_margin_start_end">16dp</dimen>

    <dimen name="accessibility_imageview_size">176dp</dimen>