Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b011c5bf authored by Arc Wang's avatar Arc Wang
Browse files

[Wi-Fi] Fix check mark button when edit the password of a secured network. 

Should handle WifiConfigUiBase#dispatchSubmit() for check mark button events.

Bug: 152144169
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ConfigureWifiEntryFragmentTest
      make RunSettingsRoboTests ROBOTEST_FILTER=ConfigureAccessPointFragmentTest
Change-Id: I35cbc1cdd6fbef3fd51aaa8dec94722e4155b7f4
parent 750ff898

src/com/android/settings/wifi/ConfigureAccessPointFragment.java

+3 −3
Original line number Diff line number Diff line
@@ -27,12 +27,12 @@ import android.view.View; 
import android.view.ViewGroup;

import android.widget.Button;



import androidx.annotation.VisibleForTesting;



import com.android.settings.R;

import com.android.settings.core.InstrumentedFragment;

import com.android.settingslib.wifi.AccessPoint;



import androidx.annotation.VisibleForTesting;



/**

 * Detail page for configuring Wi-Fi network.

 *
@@ -113,7 +113,7 @@ public class ConfigureAccessPointFragment extends InstrumentedFragment implement 


    @Override

    public void dispatchSubmit() {

        // Do nothing

        handleSubmitAction();

    }



    @Override

src/com/android/settings/wifi/ConfigureWifiEntryFragment.java

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ public class ConfigureWifiEntryFragment extends InstrumentedFragment implements 


    @Override

    public void dispatchSubmit() {

        // Do nothing

        handleSubmitAction();

    }



    @Override

tests/robotests/src/com/android/settings/wifi/ConfigureAccessPointFragmentTest.java

+7 −0
Original line number Diff line number Diff line
@@ -84,6 +84,13 @@ public class ConfigureAccessPointFragmentTest { 
        verify(mConfigureAccessPointFragment).handleSubmitAction();

    }



    @Test

    public void dispatchSubmit_shouldHandleSubmitAction() {

        mConfigureAccessPointFragment.dispatchSubmit();



        verify(mConfigureAccessPointFragment).handleSubmitAction();

    }



    @Test

    public void onClickCancelButton_shouldHandleCancelAction() {

        mConfigureAccessPointFragment.getCancelButton().performClick();

tests/robotests/src/com/android/settings/wifi/ConfigureWifiEntryFragmentTest.java

+7 −0
Original line number Diff line number Diff line
@@ -88,6 +88,13 @@ public class ConfigureWifiEntryFragmentTest { 
        verify(mConfigureWifiEntryFragment).handleSubmitAction();

    }



    @Test

    public void dispatchSubmit_shouldHandleSubmitAction() {

        mConfigureWifiEntryFragment.dispatchSubmit();



        verify(mConfigureWifiEntryFragment).handleSubmitAction();

    }



    @Test

    public void onClickCancelButton_shouldHandleCancelAction() {

        mConfigureWifiEntryFragment.getCancelButton().performClick();