Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afe44799 authored by Alison Cichowlas's avatar Alison Cichowlas
Browse files

Delay adding app settings link until data fetch returns, 

to avoid reordering/visible misplaced "additional settings
in the app" during transition.

Bug: 62051521
Test: manual with transition scale turned to 10x sloooow.
Change-Id: I50666fbcb2a14344bbdbb2f4347c8470edb96619
parent 98b67a4e

src/com/android/settings/notification/AppNotificationSettings.java

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,6 @@ public class AppNotificationSettings extends NotificationSettingsBase { 
        getPreferenceScreen().setOrderingAsAdded(true);

        setupBlock();

        addHeaderPref();

        addAppLinkPref();



        mShowLegacyChannelConfig = mBackend.onlyHasDefaultChannel(mAppRow.pkg, mAppRow.uid);

        if (mShowLegacyChannelConfig) {
@@ -120,6 +119,7 @@ public class AppNotificationSettings extends NotificationSettingsBase { 
                        return;

                    }

                    populateChannelList();

                    addAppLinkPref();

                }

            }.execute();

        }

src/com/android/settings/notification/NotificationSettingsBase.java

+1 −1
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ abstract public class NotificationSettingsBase extends SettingsPreferenceFragmen 
    }



    protected void addAppLinkPref() {

        if (mAppRow.settingsIntent != null) {

        if (mAppRow.settingsIntent != null && mAppLink == null) {

            mAppLink = new Preference(getPrefContext());

            mAppLink.setKey(KEY_APP_LINK);

            mAppLink.setOrder(500);