Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abe9246c authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Limit the number of concurrent notifs appear on screen 

To avoid an ANR in notification history

Test: Manual; with an app with 10k recent notifications
Bug: 183712803
Change-Id: Ia1340accadf43620c7b5a2c94ca1032cfe49ea59
parent ef23c240

res/layout/notification_history_app_layout.xml

+9 −8
Original line number Diff line number Diff line
@@ -81,9 +81,10 @@ 
    <com.android.settings.notification.history.NotificationHistoryRecyclerView

        android:id="@+id/notification_list"

        android:layout_width="match_parent"

            android:layout_height="wrap_content"

        android:layout_height="500dp"

        android:clipChildren="true"

        android:clipToPadding="true"

        android:clipToOutline="true"

        android:importantForAccessibility="yes"

        android:scrollbars="none"/>

src/com/android/settings/notification/history/NotificationHistoryAdapter.java

+5 −0
Original line number Diff line number Diff line
@@ -71,6 +71,11 @@ public class NotificationHistoryAdapter extends 
        return new NotificationHistoryViewHolder(view);

    }



    @Override

    public long getItemId(int position) {

        return mValues.get(position).hashCode();

    }



    @Override

    public void onBindViewHolder(final @NonNull NotificationHistoryViewHolder holder,

            int position) {

src/com/android/settings/notification/history/NotificationHistoryRecyclerView.java

+0 −1
Original line number Diff line number Diff line
@@ -40,7 +40,6 @@ public class NotificationHistoryRecyclerView extends RecyclerView { 
        ItemTouchHelper touchHelper = new ItemTouchHelper(

                new DismissTouchHelper(0, ItemTouchHelper.START | ItemTouchHelper.END));

        touchHelper.attachToRecyclerView(this);

        setNestedScrollingEnabled(false);

    }



    public void setOnItemSwipeDeleteListener(OnItemSwipeDeleteListener listener) {