Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6861564 authored Aug 15, 2024 by Weng Su

Avoid launching details settings after WifiEntry is forgotten

- Don't launch details settings if WifiEntry isn't saved

Bug: 359584817
Flag: EXEMPT bugfix
Test: Manual testing
atest -c NetworkProviderSettingsTest

Change-Id: Iff1c37b64adef6d136d2aaa6a0a946c22af38193

parent 5cbcfb07

src/com/android/settings/network/NetworkProviderSettings.java

+4 −0

Original line number	Diff line number	Diff line
		@@ -1068,6 +1068,10 @@ public class NetworkProviderSettings extends RestrictedSettingsFragment
		@VisibleForTesting
		void launchNetworkDetailsFragment(LongPressWifiEntryPreference pref) {
		final WifiEntry wifiEntry = pref.getWifiEntry();
		if (!wifiEntry.isSaved()) {
		Log.w(TAG, "launchNetworkDetailsFragment: Don't launch because WifiEntry isn't saved!");
		return;
		}
		final Context context = requireContext();

		final Bundle bundle = new Bundle();

tests/robotests/src/com/android/settings/network/NetworkProviderSettingsTest.java

+11 −0

Original line number	Diff line number	Diff line
		@@ -872,6 +872,17 @@ public class NetworkProviderSettingsTest {
		verify(mWifiEntry, never()).getKey();
		}

		@Test
		public void launchNetworkDetailsFragment_wifiEntryIsNotSaved_ignoreWifiEntry() {
		when(mWifiEntry.isSaved()).thenReturn(false);
		LongPressWifiEntryPreference preference =
		mNetworkProviderSettings.createLongPressWifiEntryPreference(mWifiEntry);

		mNetworkProviderSettings.launchNetworkDetailsFragment(preference);

		verify(mWifiEntry, never()).getKey();
		}

		@Implements(PreferenceFragmentCompat.class)
		public static class ShadowPreferenceFragmentCompat {