Merge "Add null check for vrManager" (a3738857) · Commits · e / os / android_packages_apps_Settings

src/com/android/settings/display/BrightnessLevelPreferenceController.java

+13 −5

Original line number	Diff line number	Diff line
		@@ -151,14 +151,22 @@ public class BrightnessLevelPreferenceController extends AbstractPreferenceContr
		return (value - min) / (max - min);
		}

		@VisibleForTesting
		IVrManager safeGetVrManager() {
		return IVrManager.Stub.asInterface(ServiceManager.getService(
		Context.VR_SERVICE));
		}

		@VisibleForTesting
		boolean isInVrMode() {
		IVrManager vrManager = safeGetVrManager();
		if (vrManager != null) {
		try {
		return IVrManager.Stub.asInterface(ServiceManager.getService(Context.VR_SERVICE))
		.getVrModeState();
		return vrManager.getVrModeState();
		} catch (RemoteException e) {
		Log.e(TAG, "Failed to check vr mode!", e);
		}
		}
		return false;
		}
		}

+6 −0

Original line number	Diff line number	Diff line
		@@ -84,6 +84,12 @@ public class BrightnessLevelPreferenceControllerTest {
		assertThat(mController.isAvailable()).isTrue();
		}

		@Test
		public void isInVrMode_noVrManager_shouldAlwaysReturnFalse() {
		doReturn(null).when(mController).safeGetVrManager();
		assertThat(mController.isInVrMode()).isFalse();
		}

		@Test
		public void onStart_shouldRegisterObserver() {
		BrightnessLevelPreferenceController controller =