Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ddd3445 authored by Rafael Matias de Lima's avatar Rafael Matias de Lima
Browse files

Fix for User edit info dialog during rotation 

[issue]
1. Go to Settings > System > Multiple users;
2. Edit user info;
3. Take a picture in portrait mode;
4. Turn the device to landscape mode;

Observe selected image is not retained;

[rootcause]
Fragments no longer need to check if the dialog
is showing up during onSaveInstanceState.

[test]
1. Edit user info;
2. Select a picture;
3. Turn the device to landscape mode;
parent 4f4c05ad

src/com/android/settings/users/EditUserInfoController.java

+1 −2
Original line number Diff line number Diff line
@@ -83,8 +83,7 @@ public class EditUserInfoController { 
    }



    public void onSaveInstanceState(Bundle outState) {

        if (mEditUserInfoDialog != null && mEditUserInfoDialog.isShowing()

                && mEditUserPhotoController != null) {

        if (mEditUserInfoDialog != null && mEditUserPhotoController != null) {

            // Bitmap cannot be stored into bundle because it may exceed parcel limit

            // Store it in a temporary file instead

            File file = mEditUserPhotoController.saveNewUserPhotoBitmap();