Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9db4bf7d authored by Arc Wang's avatar Arc Wang
Browse files

[Wi-Fi] Can't change EAP method for a saved enterprise Wi-Fi network 

Should only allow saved network UI initialization for once.

Bug: 140362368
Test: WifiConfigControllerTest
      manual:
      Manually change EAP method and other security fields for a saved
      Wi-Fi neterprise network.

Change-Id: Iddc1dae53849760f43b41b75262358dff6ba09af
parent 2cce2150

src/com/android/settings/wifi/WifiConfigController.java

+4 −1
Original line number Diff line number Diff line
@@ -986,7 +986,10 @@ public class WifiConfigController implements TextWatcher, 
        }

        mView.findViewById(R.id.eap).setVisibility(View.VISIBLE);



        // TODO (b/140541213): Maybe we can remove initiateEnterpriseNetworkUi by moving code block

        boolean initiateEnterpriseNetworkUi = false;

        if (mEapMethodSpinner == null) {

            initiateEnterpriseNetworkUi = true;

            mEapMethodSpinner = (Spinner) mView.findViewById(R.id.method);

            mEapMethodSpinner.setOnItemSelectedListener(this);

            mPhase2Spinner = (Spinner) mView.findViewById(R.id.phase2);
@@ -1043,7 +1046,7 @@ public class WifiConfigController implements TextWatcher, 
        }



        // Modifying an existing network

        if (mAccessPoint != null && mAccessPoint.isSaved()) {

        if (initiateEnterpriseNetworkUi && mAccessPoint != null && mAccessPoint.isSaved()) {

            WifiEnterpriseConfig enterpriseConfig = mAccessPoint.getConfig().enterpriseConfig;

            int eapMethod = enterpriseConfig.getEapMethod();

            int phase2Method = enterpriseConfig.getPhase2Method();

tests/robotests/src/com/android/settings/wifi/WifiConfigControllerTest.java

+20 −0
Original line number Diff line number Diff line
@@ -29,6 +29,8 @@ import static org.mockito.Mockito.when; 
import android.content.Context;

import android.content.res.Resources;

import android.net.wifi.WifiConfiguration;

import android.net.wifi.WifiEnterpriseConfig;

import android.net.wifi.WifiEnterpriseConfig.Eap;

import android.net.wifi.WifiManager;

import android.os.ServiceSpecificException;

import android.security.KeyStore;
@@ -526,4 +528,22 @@ public class WifiConfigControllerTest { 


        assertThat(shadowImm.isSoftInputVisible()).isFalse();

    }



    @Test

    public void selectEapMethod_savedAccessPoint_shouldGetCorrectPosition() {

        when(mAccessPoint.isSaved()).thenReturn(true);

        when(mAccessPoint.getSecurity()).thenReturn(AccessPoint.SECURITY_EAP);

        final WifiConfiguration mockWifiConfig = mock(WifiConfiguration.class);

        final WifiEnterpriseConfig mockWifiEnterpriseConfig = mock(WifiEnterpriseConfig.class);

        when(mockWifiEnterpriseConfig.getEapMethod()).thenReturn(Eap.PEAP);

        mockWifiConfig.enterpriseConfig = mockWifiEnterpriseConfig ;

        when(mAccessPoint.getConfig()).thenReturn(mockWifiConfig);

        mController = new TestWifiConfigController(mConfigUiBase, mView, mAccessPoint,

                WifiConfigUiBase.MODE_MODIFY);

        final Spinner eapMethodSpinner = mView.findViewById(R.id.method);



        eapMethodSpinner.setSelection(Eap.TLS);



        assertThat(eapMethodSpinner.getSelectedItemPosition()).isEqualTo(Eap.TLS);

    }

}