Clean the slice in onUnpinned rather than onBinded. (98f7b2b2) · Commits · e / os / android_packages_apps_Settings

src/com/android/settings/slices/SettingsSliceProvider.java

+1 −5

Original line number	Diff line number	Diff line
		@@ -187,6 +187,7 @@ public class SettingsSliceProvider extends SliceProvider {

		@Override
		public void onSliceUnpinned(Uri sliceUri) {
		mSliceWeakDataCache.remove(sliceUri);
		final Context context = getContext();
		if (!VolumeSliceHelper.unregisterUri(context, sliceUri)) {
		SliceBroadcastRelay.unregisterReceivers(context, sliceUri);
		@@ -258,11 +259,6 @@ public class SettingsSliceProvider extends SliceProvider {
		loadSliceInBackground(sliceUri);
		return getSliceStub(sliceUri);
		}

		// Remove the SliceData from the cache after it has been used to prevent a memory-leak.
		if (!getPinnedSlices().contains(sliceUri)) {
		mSliceWeakDataCache.remove(sliceUri);
		}
		return SliceBuilderUtils.buildSlice(getContext(), cachedSliceData);
		} finally {
		StrictMode.setThreadPolicy(oldPolicy);