Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 981d10db authored by Menghan Li's avatar Menghan Li Committed by Android (Google) Code Review
Browse files

Merge "Fix InvisibleToggle type service does not turn on or turn off correctly...

Merge "Fix InvisibleToggle type service does not turn on or turn off correctly when edit shortcut dialog." into rvc-dev
parents e6b7e24a de1258f9
Loading
Loading
Loading
Loading
+14 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@
package com.android.settings.accessibility;

import android.accessibilityservice.AccessibilityServiceInfo;
import android.content.DialogInterface;
import android.view.View;

import com.android.settings.R;
@@ -68,4 +69,17 @@ public class InvisibleToggleAccessibilityServicePreferenceFragment extends
                    true);
        }
    }

    /**
     * {@inheritDoc}
     *
     * Enables accessibility service when shortcutPreference is checked.
     */
    @Override
    protected void callOnAlertDialogCheckboxClicked(DialogInterface dialog, int which) {
        super.callOnAlertDialogCheckboxClicked(dialog, which);

        final boolean enabled = mShortcutPreference.isChecked();
        AccessibilityUtils.setAccessibilityServiceState(getContext(), mComponentName, enabled);
    }
}
+7 −1
Original line number Diff line number Diff line
@@ -597,7 +597,13 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference
        return shortcut.getType();
    }

    private void callOnAlertDialogCheckboxClicked(DialogInterface dialog, int which) {
    /**
     * This method will be invoked when a button in the edit shortcut dialog is clicked.
     *
     * @param dialog The dialog that received the click
     * @param which The button that was clicked
     */
    protected void callOnAlertDialogCheckboxClicked(DialogInterface dialog, int which) {
        if (mComponentName == null) {
            return;
        }
+2 −1
Original line number Diff line number Diff line
@@ -381,7 +381,8 @@ public class ToggleScreenMagnificationPreferenceFragment extends
        return shortcut.getType();
    }

    private void callOnAlertDialogCheckboxClicked(DialogInterface dialog, int which) {
    @Override
    protected void callOnAlertDialogCheckboxClicked(DialogInterface dialog, int which) {
        updateUserShortcutType(/* saveChanges= */ true);
        optInAllMagnificationValuesToSettings(getPrefContext(), mUserShortcutType);
        optOutAllMagnificationValuesFromSettings(getPrefContext(), ~mUserShortcutType);