Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 976c6ac5 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Fix color checking error of the repohooks" into sc-dev

parents f608d1e7 dd64c59f
Loading
Loading
Loading
Loading
+32 −0
Original line number Original line Diff line number Diff line
@@ -1901,6 +1901,22 @@
            column="5"/>
            column="5"/>
    </issue>
    </issue>


    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="    &lt;color name=&quot;google_grey_700&quot;>#5f6368&lt;/color>"
        errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/values/colors.xml"
            line="194"
            column="5"/>
    </issue>

    <issue
    <issue
        id="HardCodedColor"
        id="HardCodedColor"
        severity="Error"
        severity="Error"
@@ -4093,4 +4109,20 @@
            column="5"/>
            column="5"/>
    </issue>
    </issue>


    <issue
        id="HardCodedColor"
        severity="Error"
        message="Avoid using hardcoded color"
        category="Correctness"
        priority="4"
        summary="Using hardcoded color"
        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
        errorLine1="                android:color=&quot;@color/google_grey_700&quot;/>"
        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="res/drawable/ic_reduce_bright_colors.xml"
            line="21"
            column="17"/>
    </issue>

</issues>
</issues>