Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 964c7d5e authored by SongFerngWang's avatar SongFerngWang
Browse files

Refine the mobile data selection UI 

-Adding the margin for bottom at dialog
-Modify the text color of summay in the list at dialog when device is
dark mode.

Bug: 212396431
Test: build pass and check the dialog UI.
Change-Id: I1ec587fd9d64ad67bbf3479c7931c0a901f572cf
Merged-In: I1ec587fd9d64ad67bbf3479c7931c0a901f572cf
parent c854c108

res/layout/select_account_list_item.xml

+0 −1
Original line number Diff line number Diff line
@@ -36,6 +36,5 @@ 
        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_below="@id/title"

        android:textColor="?android:attr/textColorSecondary"

        android:layout_alignStart="@id/title" />

</LinearLayout>

res/values-night/styles.xml

+1 −1
Original line number Diff line number Diff line
@@ -28,6 +28,6 @@ 
    <style name="TextAppearance.SimConfirmDialogList.Summary">

        <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>

        <item name="android:fontFamily">@*android:string/config_headlineFontFamily</item>

        <item name="android:textColor">?android:attr/textColorPrimaryInverse</item>

        <item name="android:textColor">?android:attr/textColorSecondaryInverse</item>

    </style>

</resources>
 
 No newline at end of file

res/values/dimens.xml

+4 −0
Original line number Diff line number Diff line
@@ -440,4 +440,8 @@ 
    <dimen name="chartview_trapezoid_radius">5dp</dimen>

    <dimen name="chartview_trapezoid_margin_start">1dp</dimen>

    <dimen name="chartview_trapezoid_margin_bottom">2dp</dimen>



    <!-- Sims/Data mobile/Calls/SMS select dialog-->

    <dimen name="sims_select_margin_bottom">24dp</dimen>

    <dimen name="sims_select_margin_top">8dp</dimen>

</resources>

res/values/styles.xml

+1 −0
Original line number Diff line number Diff line
@@ -919,6 +919,7 @@ 


    <style name="TextAppearance.SimConfirmDialogList.Summary">

        <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>

        <item name="android:textColor">?android:attr/textColorSecondary</item>

    </style>



    <style name="SimConfirmDialog.OutlineButton" parent="@android:style/Widget.Material.Button">

src/com/android/settings/sim/SimListDialogFragment.java

+10 −0
Original line number Diff line number Diff line
@@ -200,6 +200,16 @@ public class SimListDialogFragment extends SimDialogFragment implements 
            final TextView title = convertView.findViewById(R.id.title);

            final TextView summary = convertView.findViewById(R.id.summary);



            ViewGroup.MarginLayoutParams lp =

                    (ViewGroup.MarginLayoutParams) parent.getLayoutParams();

            if (lp != null) {

                lp.setMargins(0, mContext.getResources().getDimensionPixelSize(

                        R.dimen.sims_select_margin_top), 0,

                        mContext.getResources().getDimensionPixelSize(

                                R.dimen.sims_select_margin_bottom));

                convertView.setLayoutParams(lp);

            }



            if (sub == null) {

                if (position == 0) {

                    title.setText(R.string.sim_calls_ask_first_prefs_title);