Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f3a25bf authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

Settings: switch to using ctl.start property instead of exec logcat 

- Moves policy of what to do with buffer size changes to logd

Bug: 23685592
Change-Id: Ib80a755213742dbf806a6f4423d5a709de2da645
parent 24eaa7ed

src/com/android/settings/DevelopmentSettings.java

+1 −7
Original line number Diff line number Diff line
@@ -1311,14 +1311,8 @@ public class DevelopmentSettings extends SettingsPreferenceFragment 
        final String size = (newValue != null) ?

                newValue.toString() : DEFAULT_LOG_RING_BUFFER_SIZE_IN_BYTES;

        SystemProperties.set(SELECT_LOGD_SIZE_PROPERTY, size);

        SystemProperties.set("ctl.start", "logd-reinit");

        pokeSystemProperties();

        try {

            Process p = Runtime.getRuntime().exec("logcat -b all -G " + size);

            p.waitFor();

            Log.i(TAG, "Logcat ring buffer sizes set to: " + size);

        } catch (Exception e) {

            Log.w(TAG, "Cannot set logcat ring buffer sizes", e);

        }

        updateLogdSizeValues();

    }