Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d9b2656 authored by Emily Chuang's avatar Emily Chuang
Browse files

Give SliceView a height to support four rows and show more button. 

The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.

Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
parent 51814935

res/layout/homepage_slice_tile.xml

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ 
    <androidx.slice.widget.SliceView

        android:id="@+id/slice_view"

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:layout_height="@dimen/homepage_slice_card_max_height"

        android:paddingStart="@dimen/homepage_card_padding_start"

        android:paddingEnd="@dimen/homepage_card_padding_end"

        android:paddingTop="@dimen/homepage_card_padding_top"

res/values/dimens.xml

+4 −0
Original line number Diff line number Diff line
@@ -350,6 +350,10 @@ 
    <dimen name="homepage_card_padding_top">6dp</dimen>

    <dimen name="homepage_card_padding_bottom">6dp</dimen>



    <!-- Slice cards maximum height (4 rows + show more)

        MODE_LARGE height(3 rows + show more) 240dp + one line text(1 row) 48dp = 288dp -->

    <dimen name="homepage_slice_card_max_height">288dp</dimen>



    <!-- Signal icon in NetworkSelectSetting -->

    <dimen name="signal_strength_icon_size">24dp</dimen>