Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c8c4077 authored by Fan Zhang's avatar Fan Zhang
Browse files

Fix a monkey crash when it dismisses suggestion. 

Change-Id: I300a49ed75381795b6532388f770847ed39a4c8c
Fix: 36509330
Test: make RunSettingsRoboTests
parent aaa042de

src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ public class SuggestionFeatureProviderImpl implements SuggestionFeatureProvider 


    @Override

    public void dismissSuggestion(Context context, SuggestionParser parser, Tile suggestion) {

        if (parser == null || suggestion == null) {

        if (parser == null || suggestion == null || context == null) {

            return;

        }

        mMetricsFeatureProvider.action(

tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java

+8 −0
Original line number Diff line number Diff line
@@ -120,6 +120,14 @@ public class SuggestionFeatureProviderImplTest { 
        verify(mContext, never()).getPackageManager();

    }





    @Test

    public void dismissSuggestion_noContext_shouldDoNothing() {

        mProvider.dismissSuggestion(null, mSuggestionParser, mSuggestion);



        verifyZeroInteractions(mFactory.metricsFeatureProvider);

    }



    @Test

    public void dismissSuggestion_hasNoMoreDismissCount_shouldDisableComponent() {

        when(mSuggestionParser.dismissSuggestion(any(Tile.class), anyBoolean()))