Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 897a0e04 authored by Bernardo Rufino's avatar Bernardo Rufino
Browse files

Ignore "package:<package>" in MANAGE_OVERLAY_PERMISSION intent 

Before this change, intents with action = MANAGE_OVERLAY_PERMISSION and data =
URI "package:<package>" would redirect the user to the specific app screen with
the toggle to grant SYSTEM_ALERT_WINDOW (SAW) permission.

This makes it too easy for malicious apps to fool the user into enabling
it and we know that exist malware attempts to do so.

This CL redirects that intent to the screen that list all the apps
requesting SAW permission, introducing some friction for the user, which
hopefully will allow more time for consideration.

This is consistent with how other access permission intents work.

Test: Working on CTS
Test: adb shell am start -a
      android.settings.action.MANAGE_OVERLAY_PERMISSION -d package:<package>
      goes to list of apps screen
Test: adb shell am start -a android.settings.action.MANAGE_OVERLAY_PERMISSION
      also goes there
Bug: 135920175

Change-Id: I02fb842106602dab7fc285d0741edb58432ac7ad
parent b499cc56

AndroidManifest.xml

+1 −8
Original line number Diff line number Diff line
@@ -2701,20 +2701,13 @@ 
                <action android:name="android.settings.action.MANAGE_OVERLAY_PERMISSION" />

                <category android:name="android.intent.category.DEFAULT" />

            </intent-filter>

            <meta-data android:name="com.android.settings.FRAGMENT_CLASS"

                android:value="com.android.settings.applications.manageapplications.ManageApplications" />

        </activity>



        <activity

            android:name="Settings$AppDrawOverlaySettingsActivity"

            android:label="@string/draw_overlay">

            <intent-filter android:priority="1">

                <action android:name="android.settings.action.MANAGE_OVERLAY_PERMISSION" />

                <category android:name="android.intent.category.DEFAULT" />

                <data android:scheme="package" />

            </intent-filter>

            <meta-data android:name="com.android.settings.FRAGMENT_CLASS"

                android:value="com.android.settings.applications.appinfo.DrawOverlayDetails" />

                android:value="com.android.settings.applications.manageapplications.ManageApplications" />

        </activity>



        <activity

src/com/android/settings/Settings.java

+0 −1
Original line number Diff line number Diff line
@@ -137,7 +137,6 @@ public class Settings extends SettingsActivity { 
    public static class OverlaySettingsActivity extends SettingsActivity { /* empty */ }

    public static class WriteSettingsActivity extends SettingsActivity { /* empty */ }

    public static class ChangeWifiStateActivity extends SettingsActivity { /* empty */ }

    public static class AppDrawOverlaySettingsActivity extends SettingsActivity { /* empty */ }

    public static class AppWriteSettingsActivity extends SettingsActivity { /* empty */ }



    public static class ManageExternalSourcesActivity extends SettingsActivity {/* empty */ }