Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cbd5cac authored by Shawn Lin's avatar Shawn Lin
Browse files

Fixed A11y issues 

- announce "Fingerprint not recognized" when check enrolled fingerprint
  failed
- announce "Finger name + double tap to rename" when fingerprint item is
  focused

Bug: 406708477
Bug: 406710632
Test: manual: enable talk back and check fingerprint settings
Flag: EXEMPT bug fix
Change-Id: Id2d80c6035883450b4cdc48d850ef4316995f206
parent 5eb5b95b

res/layout/fingerprint_check_enrolled_dialog.xml

+2 −1
Original line number Diff line number Diff line
@@ -41,7 +41,8 @@ 
            android:layout_centerHorizontal="true"

            android:textSize="18sp"

            android:textColor="@android:color/white"

            android:text="@string/fingerprint_check_enroll_touch_sensor"/>

            android:text="@string/fingerprint_check_enroll_touch_sensor"

            android:accessibilityLiveRegion="assertive"/>



    </com.android.settings.biometrics.fingerprint.UdfpsCheckEnrolledView>

</RelativeLayout>
 
 No newline at end of file

res/values/strings.xml

+2 −0
Original line number Diff line number Diff line
@@ -1042,6 +1042,8 @@ 
    <string name="security_settings_fingerprint_enroll_introduction_no_thanks">Not now</string>

    <!-- Button text to agree the consent and continue to the next screen from the introduction [CHAR LIMIT=22] -->

    <string name="security_settings_fingerprint_enroll_introduction_agree">I agree</string>

    <!-- The content description for rename a fingerprint. [CHAR LIMIT=100] -->

    <string name="security_settings_fingerprint_rename_description">Double tap to rename</string>

    <!-- Title of dialog shown when the user tries to skip setting up fingerprint after adding lock screen during initial setup. [CHAR LIMIT=30] -->

    <string name="setup_fingerprint_enroll_skip_title">Skip fingerprint?</string>

    <!-- Body text of dialog shown when the user tries to skip setting up fingerprint after adding lock screen during initial setup [CHAR LIMIT=NONE] -->

src/com/android/settings/biometrics/fingerprint/FingerprintSettings.java

+6 −0
Original line number Diff line number Diff line
@@ -2016,8 +2016,14 @@ public class FingerprintSettings extends SubSettings { 
        public void onBindViewHolder(PreferenceViewHolder view) {

            super.onBindViewHolder(view);

            mView = view.itemView;

            final TextView title = (TextView) view.findViewById(android.R.id.title);

            mDeleteView = view.itemView.findViewById(R.id.delete_button);

            if (mFingerprint != null) {

                if (title != null) {

                    title.setContentDescription(

                            mFingerprint.getName().toString() + " " + getContext().getString(

                                    R.string.security_settings_fingerprint_rename_description));

                }

                mDeleteView.setContentDescription(

                        mDeleteView.getContentDescription()

                                + " " + mFingerprint.getName().toString());