Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b9e3fdd authored by Daniel Sheng's avatar Daniel Sheng
Browse files

Camera lift preference now saves correctly 

Bug: 37751057
Test: manual + make RunSettingsRoboTests

Fixed issue where camera lift preference was saving the opposite value
of what it was supposed to. Added test to cover saving of value on
preference change.

Change-Id: I2d2c454eb478afb7f73519f9f05c9a9a1933938b
parent 5c5830f8

src/com/android/settings/gestures/CameraLiftTriggerPreferenceController.java

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ public class CameraLiftTriggerPreferenceController extends GesturePreferenceCont 
    public boolean onPreferenceChange(Preference preference, Object newValue) {

        boolean enabled = (boolean) newValue;

        Settings.Secure.putInt(mContext.getContentResolver(),

                Settings.Secure.CAMERA_LIFT_TRIGGER_ENABLED, enabled ? 0 : 1);

                Settings.Secure.CAMERA_LIFT_TRIGGER_ENABLED, enabled ? 1 : 0);

        return true;

    }

tests/robotests/src/com/android/settings/gestures/CameraLiftTriggerPreferenceControllerTest.java

+22 −0
Original line number Diff line number Diff line
@@ -100,4 +100,26 @@ public class CameraLiftTriggerPreferenceControllerTest { 


        assertThat(mController.isSwitchPrefEnabled()).isTrue();

    }



    @Test

    public void testEnablePreference_shouldSetSetting() {

        final Context context = RuntimeEnvironment.application;

        mController = new CameraLiftTriggerPreferenceController(context, null,

                KEY_CAMERA_LIFT_TRIGGER);

        mController.onPreferenceChange(null, true);



        assertThat(Settings.Secure.getInt(context.getContentResolver(),

                CAMERA_LIFT_TRIGGER_ENABLED, 0)).isEqualTo(1);

    }



    @Test

    public void testDisablePreference_shouldClearSetting() {

        final Context context = RuntimeEnvironment.application;

        mController = new CameraLiftTriggerPreferenceController(context, null,

                KEY_CAMERA_LIFT_TRIGGER);

        mController.onPreferenceChange(null, false);



        assertThat(Settings.Secure.getInt(context.getContentResolver(),

                CAMERA_LIFT_TRIGGER_ENABLED, 1)).isEqualTo(0);

    }

}