Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 788e0e4d authored by Aleksander Morgado's avatar Aleksander Morgado
Browse files

Don't assume telephony is available in MobileNetworkSettingsSearchIndexTest

The test would otherwise fail on a device that doesn't have telephony
support.

Bug: 395714454
Test: atest MobileNetworkSettingsSearchIndexTest
FLAG: TEST_ONLY

Change-Id: Ib6ce205af053c27b8a6763c945ae5356a74286b3
parent 32bc5aab
Loading
Loading
Loading
Loading
+23 −3
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@
package com.android.settings.network.telephony

import android.content.Context
import android.content.pm.PackageManager
import android.os.UserManager
import android.provider.Settings
import android.telephony.SubscriptionInfo
@@ -45,6 +46,8 @@ class MobileNetworkSettingsSearchIndexTest {

    private val mockUserManager = mock<UserManager> { on { isAdminUser } doReturn true }

    private val mockPackageManager = mock<PackageManager>()

    private val mockSubscriptionManager =
        mock<SubscriptionManager> {
            on { activeSubscriptionInfoList } doReturn listOf(SUB_INFO_1, SUB_INFO_2)
@@ -55,6 +58,7 @@ class MobileNetworkSettingsSearchIndexTest {
            on { getSystemService(UserManager::class.java) } doReturn mockUserManager
            on { getSystemService(SubscriptionManager::class.java) } doReturn
                mockSubscriptionManager
            on { packageManager } doReturn mockPackageManager
        }

    private val resources =
@@ -75,12 +79,17 @@ class MobileNetworkSettingsSearchIndexTest {
    @Before
    fun setUp() {
        context.stub { on { resources } doReturn resources }
    }

    @Test
    fun isMobileNetworkSettingsSearchable_adminUser_returnTrue() {
        // By default, searchable
        mockUserManager.stub { on { isAdminUser } doReturn true }
        mockPackageManager.stub {
            on { hasSystemFeature(PackageManager.FEATURE_TELEPHONY) } doReturn true
        }
    }

    @Test
    fun isMobileNetworkSettingsSearchable_default_returnTrue() {
        // Use defaults
        val isSearchable = isMobileNetworkSettingsSearchable(context)

        assertThat(isSearchable).isTrue()
@@ -95,6 +104,17 @@ class MobileNetworkSettingsSearchIndexTest {
        assertThat(isSearchable).isFalse()
    }

    @Test
    fun isMobileNetworkSettingsSearchable_noTelephony_returnFalse() {
        mockPackageManager.stub {
            on { hasSystemFeature(PackageManager.FEATURE_TELEPHONY) } doReturn false
        }

        val isSearchable = isMobileNetworkSettingsSearchable(context)

        assertThat(isSearchable).isFalse()
    }

    @Test
    fun createSearchIndexableData() {
        val searchIndexableData = mobileNetworkSettingsSearchIndex.createSearchIndexableData()