Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77dfb359 authored by jasonwshsu's avatar jasonwshsu Committed by Jason Hsu
Browse files

Fix failure test cases in AccessibilityShortcutPreferenceFragmentTest 

Root Cause: The lifecycle for
AccessibilityShortcutPreferenceFragmentTest did not be called correctly.

Solution:
* Call onAttach() before onCreate() to set some configs correctly, e.g.
FeatureFactory.
* Use ShadowFragment.class that we usually do in accessibility
tests.

Fix: 200906425
Fix: 201020915
Test: atest AccessibilityShortcutPreferenceFragmentTest
Change-Id: I3391c0a4a2c7c361a44c7d282b1d5d3e75a28a39
Merged-In: I3391c0a4a2c7c361a44c7d282b1d5d3e75a28a39
parent 504cc273

tests/robotests/src/com/android/settings/accessibility/AccessibilityShortcutPreferenceFragmentTest.java

+3 −1
Original line number Diff line number Diff line
@@ -180,8 +180,8 @@ public class AccessibilityShortcutPreferenceFragmentTest { 
        savedInstanceState.putInt(KEY_SAVED_USER_SHORTCUT_TYPE,

                AccessibilityUtil.UserShortcutType.SOFTWARE

                        | AccessibilityUtil.UserShortcutType.HARDWARE);

        mFragment.onCreate(savedInstanceState);

        mFragment.onAttach(mContext);

        mFragment.onCreate(savedInstanceState);

        mFragment.setupEditShortcutDialog(dialog);

        final int value = mFragment.getShortcutTypeCheckBoxValue();

        mFragment.saveNonEmptyUserShortcutType(value);
@@ -195,9 +195,11 @@ public class AccessibilityShortcutPreferenceFragmentTest { 
    }



    @Test

    @Config(shadows = ShadowFragment.class)

    public void showGeneralCategory_shouldInitCategory() {

        final Bundle savedInstanceState = new Bundle();

        when(mFragment.showGeneralCategory()).thenReturn(true);

        mFragment.onAttach(mContext);

        mFragment.onCreate(savedInstanceState);



        verify(mFragment).initGeneralCategory();